Logging and diagnostics #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mhutch
commented
Jul 11, 2023
mhutch
commented
- Improve the diagnostics model, and improve testing of diagnostics
- More exception logging
- Better support EOF in parser
This is a Roslyn-like model that separates the disgnostic descriptor from the diagnostics. Also includes improvements to some of the diagnostics. Some tests now cover specific diagnostics rather thna just the count.
The parser can now end all nodes properly on EOF, ensuring they have correct positions and warnings, and that they capture any availble partial information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.