Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade from net481 to net48 for VS compat #92

Merged
merged 1 commit into from
May 9, 2024
Merged

Downgrade from net481 to net48 for VS compat #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Core.Tests/MonoDevelop.Xml.Core.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

<PropertyGroup>
<TargetFrameworks>net8.0</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('Windows'))">net481;net8.0</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('Windows'))">net48;net8.0</TargetFrameworks>
<NUnitDisableSupportAssemblies>true</NUnitDisableSupportAssemblies>
<RootNamespace>MonoDevelop.Xml.Tests</RootNamespace>
</PropertyGroup>

<PropertyGroup>
<Nullable>enable</Nullable>
<Nullable Condition="$(TargetFramework)=='net481'">annotations</Nullable>
<Nullable Condition="$(TargetFramework)=='net48'">annotations</Nullable>
</PropertyGroup>

<ItemGroup>
Expand Down
6 changes: 3 additions & 3 deletions Core/MonoDevelop.Xml.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net481;net8.0</TargetFrameworks>
<TargetFrameworks>net48;net8.0</TargetFrameworks>
<!--
The assembly is called MonoDevelop.Xml.Core so as not to conflict with the original extension assembly in MonoDevelop
but the root namespace is still MonoDevelop.Xml
Expand All @@ -11,12 +11,12 @@

<PropertyGroup>
<Nullable>enable</Nullable>
<Nullable Condition="$(TargetFramework)=='net481'">annotations</Nullable>
<Nullable Condition="$(TargetFramework)=='net48'">annotations</Nullable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
<PackageReference Include="System.Collections.Immutable" />
<PackageReference Include="Microsoft.Bcl.HashCode" Condition="'$(TargetFramework)'=='net481'" />
<PackageReference Include="Microsoft.Bcl.HashCode" Condition="'$(TargetFramework)'=='net48'" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion Editor.Tests/MonoDevelop.Xml.Editor.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFrameworks>net8.0</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('Windows'))">net481;net8.0</TargetFrameworks>
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('Windows'))">net48;net8.0</TargetFrameworks>
<NUnitDisableSupportAssemblies>true</NUnitDisableSupportAssemblies>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion Editor/MonoDevelop.Xml.Editor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net481;net8.0</TargetFrameworks>
<TargetFrameworks>net48;net8.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion external/MiniEditor
Open in desktop
Submodule MiniEditor updated 1 files
+3 −2 Microsoft.VisualStudio.MiniEditor/Microsoft.VisualStudio.MiniEditor.csproj
Loading