Add more psrfits setter and column initialization. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhvk
reviewed
Aug 28, 2019
| self.data_hdu = data_hdu | ||
|
|
||
| @property | ||
| def data(self): |
There was a problem hiding this comment.
What about making this a lazyproperty that does init_columns? That way, we can get rid of init_columns...
There was a problem hiding this comment.
p.s. Obviously, only if data_hdu.data doesn't exist.
There was a problem hiding this comment.
That is a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the column initialization and more setter. It comes with an updated test case.