feat: failing tests are now all grouped at bottom in output

mhweiner · Aug 19, 2024 · 6810c65 · 6810c65
1 parent 87f0aa9
commit 6810c65
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 19 deletions.
diff --git a/src/output.ts b/src/output.ts
@@ -1,7 +1,7 @@
 import kleur from 'kleur';
 import {TestResultsByFile, FinalResults} from './run';
 import {isTestPassing} from './isTestPassing';
-import {Assertion} from './test';
+import {Assertion, TestResults} from './test';
 import {deserializeError, ErrorObject} from 'serialize-error';
 
 const log = console.log;
@@ -17,31 +17,34 @@ The following spec files do not have any attempted or completed tests:
 ${files.join(', ')}
 `);
 
-export function printFileResults(resultsByFile: TestResultsByFile) {
+export function printResultsByFile(resultsByFile: TestResultsByFile) {
 
-    const files = Object.entries(resultsByFile);
+    const passedFiles = Object.entries(resultsByFile).filter(([, tests]) => tests.every(isTestPassing));
+    const failedFiles = Object.entries(resultsByFile).filter(([, tests]) => tests.some((test) => !isTestPassing(test)));
 
-    files.forEach((file) => {
+    passedFiles.forEach(([filename, tests]) => printFileResults(filename, tests));
+    failedFiles.forEach(([filename, tests]) => printFileResults(filename, tests));
 
-        const [filename, tests] = file;
-        const header = `${kleur.underline().blue(filename)}\n`;
+}
+
+export function printFileResults(filename: string, tests: TestResults[]) {
 
-        log(header);
-        tests.forEach(((test) => {
+    const header = `${kleur.underline().blue(filename)}\n`;
 
-            log(`${test.description} ${isTestPassing(test) ? successSymbol : failureSymbol}`);
-            test.assertions.forEach((assertion) => {
+    log(header);
+    tests.forEach(((test) => {
 
-                log(kleur.gray(`  ${assertion.description} ${assertion.pass ? successSymbol : failureSymbol}`));
-                !assertion.pass && printFailedAssertionDiag(assertion);
+        log(`${test.description} ${isTestPassing(test) ? successSymbol : failureSymbol}`);
+        test.assertions.forEach((assertion) => {
 
-            });
-            test.error && printError(test.error);
-            log('');
+            log(kleur.gray(`  ${assertion.description} ${assertion.pass ? successSymbol : failureSymbol}`));
+            !assertion.pass && printFailedAssertionDiag(assertion);
 
-        }));
+        });
+        test.error && printError(test.error);
+        log('');
 
-    });
+    }));
 
 }
 

diff --git a/src/run.ts b/src/run.ts
@@ -1,6 +1,6 @@
 import {TestResults} from './test';
 import ora from 'ora';
-import {printFileResults, printSummary} from './output';
+import {printResultsByFile, printSummary} from './output';
 import {calculateFinalResults} from './calculateFinalResults';
 import {workerPool} from './workerPool';
 import {shouldExitWithError} from './shouldExitWithError';
@@ -49,7 +49,7 @@ function finish(specFiles: string[]) {
 
     const finalResults = calculateFinalResults(specFiles, testResultsByFile);
 
-    printFileResults(testResultsByFile);
+    printResultsByFile(testResultsByFile);
     printSummary(finalResults);
     if (shouldExitWithError(finalResults)) process.exit(1);