Make curl_opt local variable so it does not leak between requests #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komapa
commented
Mar 21, 2018
| @@ -143,7 +143,7 @@ HELP | |||
| [[ $# -gt 0 ]] && shift | |||
| fi | |||
|
|
|||
| local -a all_opts curlopt_cmd | |||
| local -a all_opts curl_opt curlopt_cmd | |||
pedroxs
approved these changes
Mar 27, 2018
|
Any chance to get this merged? |
This was referenced May 14, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the scope of curl_opt so that it does not leak between requests. Before this fix, if you issue a HEAD and then a GET, you are still getting the
-Iparameter and causes the GET to be treated as a HEAD.This includes the fixes from #80 and will wait for that to get merged (soon?) and then rebase mine.