Skip to content

fixup: remove runtime panics from the DTS parser #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmsyn wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fixup: remove runtime panics from the DTS parser #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1cfef25
dts_parser: remove `unwrap` calls to avoid runtime panics
rmsyn Jan 11, 2024
26b97ee
dts_parser: remove unwrap from pre_process
rmsyn Jan 11, 2024
ab023ce
dts_parser: make parse_node fallible
rmsyn Jan 11, 2024
376060c
dts_parser: remove panics from parse_node_value
rmsyn Jan 11, 2024
d651c84
dts_parser: remove panics from parse_tree
rmsyn Jan 11, 2024
b87ea2e
dts_parser: make parse fallible
rmsyn Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/devicetree.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,14 @@ impl DeviceTree {

/// Create a `Tree` from DTS text byte array.
pub fn from_dts_bytes(dts: &[u8]) -> Self {
DtsParser::from_bytes(&dts).parse()
// FIXME: make this function fallible, and bubble-up the error instead of silently failing
match DtsParser::from_bytes(&dts).parse() {
Ok(tree) => tree,
Err(err) => {
println!("Error parsing the DTS tree: {err}");
Self::new(vec![], Node::new(""))
}
}
}

/// Generate the DTS text of a `Tree`.
Expand Down
Loading