Skip to content

Conversation

@michaelm-openai
Copy link
Owner

No description provided.

@michaelm-openai michaelm-openai marked this pull request as ready for review January 16, 2026 04:25
@github-actions

This comment has been minimized.

@michaelm-openai michaelm-openai force-pushed the test_disallow_str_iteration_against_mypy_primer branch from 1cbfef1 to 64f10a2 Compare January 16, 2026 05:00
@github-actions

This comment has been minimized.

@michaelm-openai michaelm-openai force-pushed the test_disallow_str_iteration_against_mypy_primer branch from 64f10a2 to 584457a Compare January 16, 2026 05:24
@github-actions

This comment has been minimized.

@michaelm-openai michaelm-openai force-pushed the test_disallow_str_iteration_against_mypy_primer branch from 584457a to b68427b Compare January 16, 2026 07:46
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@michaelm-openai michaelm-openai force-pushed the test_disallow_str_iteration_against_mypy_primer branch from 955ee06 to a2252a2 Compare January 16, 2026 09:40
@github-actions

This comment has been minimized.

@michaelm-openai michaelm-openai force-pushed the test_disallow_str_iteration_against_mypy_primer branch from a2252a2 to 2264006 Compare January 16, 2026 21:22
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@michaelm-openai michaelm-openai force-pushed the test_disallow_str_iteration_against_mypy_primer branch from 1dfa9da to f925578 Compare January 18, 2026 08:02
@github-actions

This comment has been minimized.

@michaelm-openai michaelm-openai force-pushed the test_disallow_str_iteration_against_mypy_primer branch 2 times, most recently from 818c95f to b4d9fd6 Compare January 19, 2026 04:41
@github-actions

This comment has been minimized.

@michaelm-openai michaelm-openai force-pushed the test_disallow_str_iteration_against_mypy_primer branch from f590891 to b4d9fd6 Compare January 19, 2026 06:28
@github-actions

This comment has been minimized.

@michaelm-openai michaelm-openai force-pushed the test_disallow_str_iteration_against_mypy_primer branch 2 times, most recently from 4f028a0 to af07104 Compare January 19, 2026 08:38
@michaelm-openai michaelm-openai force-pushed the master branch 2 times, most recently from 902042e to d585f55 Compare January 19, 2026 09:15
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions
Copy link

Diff from mypy_primer, showing the effect of this PR on open source code:

optuna (https://github.com/optuna/optuna)
+ tests/samplers_tests/test_grid.py:52: error: Non-overlapping equality check (left operand type: "set[tuple[str | float | int | None, ...]]", right operand type: "set[tuple[Sequence[str | float | int | bool | None], ...]]")  [comparison-overlap]

zulip (https://github.com/zulip/zulip)
+ zerver/tests/test_invite.py:239: error: Need type annotation for "payload"  [var-annotated]

scrapy (https://github.com/scrapy/scrapy)
- scrapy/http/request/form.py:109: error: Redundant cast to "Iterable[str]"  [redundant-cast]

cki-lib (https://gitlab.com/cki-project/cki-lib)
- tests/kcidb/test_validate.py:348: error: Value of type "Collection[Collection[str]]" is not indexable  [index]
+ tests/kcidb/test_validate.py:348: error: Value of type "Collection[object]" is not indexable  [index]
- tests/kcidb/test_validate.py:384: error: Value of type "Collection[Collection[str]]" is not indexable  [index]
+ tests/kcidb/test_validate.py:384: error: Value of type "Collection[object]" is not indexable  [index]
- tests/kcidb/test_validate.py:398: error: Value of type "Collection[Collection[str]]" is not indexable  [index]
+ tests/kcidb/test_validate.py:398: error: Value of type "Collection[object]" is not indexable  [index]

core (https://github.com/home-assistant/core)
+ homeassistant/helpers/template/extensions/collection.py:92: error: Subclass of "Iterable[Any]" and "str" cannot exist: would have inconsistent method resolution order  [unreachable]
+ homeassistant/helpers/template/extensions/collection.py:133: error: Subclass of "Iterable[Any]" and "str" cannot exist: would have inconsistent method resolution order  [unreachable]
+ homeassistant/helpers/template/extensions/collection.py:135: error: Subclass of "Iterable[Any]" and "str" cannot exist: would have inconsistent method resolution order  [unreachable]
+ homeassistant/helpers/template/extensions/collection.py:142: error: Subclass of "Iterable[Any]" and "str" cannot exist: would have inconsistent method resolution order  [unreachable]
+ homeassistant/helpers/template/extensions/collection.py:144: error: Subclass of "Iterable[Any]" and "str" cannot exist: would have inconsistent method resolution order  [unreachable]
+ homeassistant/helpers/template/extensions/collection.py:151: error: Subclass of "Iterable[Any]" and "str" cannot exist: would have inconsistent method resolution order  [unreachable]
+ homeassistant/helpers/template/extensions/collection.py:153: error: Subclass of "Iterable[Any]" and "str" cannot exist: would have inconsistent method resolution order  [unreachable]
+ homeassistant/helpers/template/extensions/collection.py:162: error: Subclass of "Iterable[Any]" and "str" cannot exist: would have inconsistent method resolution order  [unreachable]
+ homeassistant/helpers/template/extensions/collection.py:166: error: Subclass of "Iterable[Any]" and "str" cannot exist: would have inconsistent method resolution order  [unreachable]
+ homeassistant/components/reolink/util.py:73: error: Type argument "str" of "Store" must be a subtype of "Mapping[str, Any] | Sequence[Any]"  [type-var]
+ homeassistant/components/reolink/util.py:75: error: Value of type variable "_T" of "Store" cannot be "str"  [type-var]
+ homeassistant/components/reolink/host.py:183: error: Type argument "str" of "Store" must be a subtype of "Mapping[str, Any] | Sequence[Any]"  [type-var]
+ homeassistant/components/met_eireann/weather.py:39: error: Unsupported right operand type for in ("object")  [operator]

urllib3 (https://github.com/urllib3/urllib3)
- src/urllib3/_collections.py:359: error: Redundant cast to "Iterable[tuple[str, str]]"  [redundant-cast]

pandas (https://github.com/pandas-dev/pandas)
+ pandas/io/formats/style_render.py:377: error: "object" has no attribute "extend"  [attr-defined]
+ pandas/io/formats/style_render.py:378: error: "object" has no attribute "extend"  [attr-defined]
+ pandas/io/formats/style_render.py:379: error: "object" has no attribute "extend"  [attr-defined]
+ pandas/tests/test_sorting.py:358: error: Value of type variable "_ScalarT" of "array" cannot be "object"  [type-var]
+ pandas/tests/test_sorting.py:359: error: Value of type variable "_ScalarT" of "array" cannot be "object"  [type-var]
+ pandas/tests/indexes/interval/test_constructors.py:150: error: Value of type variable "_ScalarT" of "array" cannot be "object"  [type-var]

ibis (https://github.com/ibis-project/ibis)
- ibis/expr/types/strings.py:958: error: Need type annotation for "pattern"  [var-annotated]
- ibis/expr/types/strings.py:1002: error: Need type annotation for "pattern"  [var-annotated]

black (https://github.com/psf/black)
+ src/blib2to3/pytree.py:660:35: error: Subclass of "Iterable[str]" and "str" cannot exist: would have inconsistent method resolution order  [unreachable]

pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ tests/test_plotting.py:546: error: Expression is of type "Any", not "Axes"  [assert-type]
+ tests/series/test_series.py:2467: error: Expression is of type "Any | None", not "str | None"  [assert-type]
+ tests/series/test_series.py:2468: error: Expression is of type "Any | None", not "str | None"  [assert-type]
+ tests/series/test_series.py:2469: error: Expression is of type "Any | None", not "str | None"  [assert-type]
+ tests/series/test_series.py:2470: error: Expression is of type "Any | None", not "str | None"  [assert-type]
+ tests/series/test_series.py:2471: error: Expression is of type "Any", not "str"  [assert-type]
+ tests/series/test_series.py:2472: error: Expression is of type "Any", not "str | bool"  [assert-type]

apprise (https://github.com/caronc/apprise)
- apprise/apprise.py:850: error: "Collection[str]" has no attribute "append"  [attr-defined]
+ apprise/apprise.py:850: error: "object" has no attribute "append"  [attr-defined]

materialize (https://github.com/MaterializeInc/materialize)
- misc/python/materialize/cli/orchestratord.py:312: error: Unsupported target for indexed assignment ("Collection[str]")  [index]
+ misc/python/materialize/cli/orchestratord.py:312: error: Unsupported target for indexed assignment ("object")  [index]
- misc/python/materialize/cli/orchestratord.py:315: error: Unsupported target for indexed assignment ("Collection[str]")  [index]
+ misc/python/materialize/cli/orchestratord.py:315: error: Unsupported target for indexed assignment ("object")  [index]

mkdocs (https://github.com/mkdocs/mkdocs)
+ mkdocs/config/config_options.py:371: error: Subclass of "Collection[T]" and "str" cannot exist: would have inconsistent method resolution order  [unreachable]

rotki (https://github.com/rotki/rotki)
+ rotkehlchen/chain/arbitrum_one/modules/gmx/balances.py:140: error: Value of type "object" is not indexable  [index]
+ rotkehlchen/chain/arbitrum_one/modules/gmx/balances.py:147: error: Value of type "object" is not indexable  [index]

static-frame (https://github.com/static-frame/static-frame)
+ static_frame/core/type_blocks.py:408: error: Subclass of "Sequence[Any]" and "str" cannot exist: would have inconsistent method resolution order  [unreachable]

cloud-init (https://github.com/canonical/cloud-init)
- tests/unittests/sources/test_lxd.py:325: error: Statement is unreachable  [unreachable]

xarray (https://github.com/pydata/xarray)
+ xarray/namedarray/utils.py:181: error: "yield from" can't be applied to "str | Iterable[Hashable]"  [misc]

nox (https://github.com/wntrblm/nox)
+ nox/_option_set.py:52: error: Value of type variable "_I" of "deep_iterable" cannot be "str"  [type-var]```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants