Fix setting groups via web ui #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
requested changes
Mar 18, 2024
zdohnal
force-pushed
the
fix-setting-groups
branch
from
ca391ae
to
200ddb6
Compare
zdohnal
force-pushed
the
fix-setting-groups
branch
from
200ddb6
to
988b90a
Compare
The template is generated incorrectly, so when form data are sent via POST, it does not contain new values for groups to save. Additionally, set the default value to empty string and make sure the code does not take the value as a bad value.
michaelrsweet
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template is generated incorrectly, so when form data are sent via POST, it does not contain new values for groups to save.
Additionally, set the default value to
noneand make sure the code does not take the value as a bad value.