Skip to content

Commit

Permalink
wpcs: align with WPCS v3.0
Browse files Browse the repository at this point in the history
code complexity: split shibboleth_option_page() into tab functions
composer: allow phpcodesniffer-composer-installer
phpcs: remove installed_paths override (its automatic now)
phpcs: add expected space after function keyword
  • Loading branch information
jrchamp committed Aug 25, 2023
1 parent 012fdcc commit e4dc73f
Show file tree
Hide file tree
Showing 6 changed files with 806 additions and 746 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/wp-plugin-ci-full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ jobs:

- name: Run PHPCS on all files
run: |
vendor/bin/phpcs -q -n --ignore=vendor --runtime-set installed_paths vendor/wp-coding-standards/wpcs --standard=WordPress --report=checkstyle $GITHUB_WORKSPACE | cs2pr
vendor/bin/phpcs -q -n --ignore=vendor --standard=WordPress --report=checkstyle $GITHUB_WORKSPACE | cs2pr
2 changes: 1 addition & 1 deletion .github/workflows/wp-plugin-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ jobs:
run: |
touch $GITHUB_WORKSPACE/tmp.php
export CHANGED_FILES=$(git diff --name-only --diff-filter=AM remotes/origin/${{ github.base_ref }} | tr '\n' ' ')
vendor/bin/phpcs -q -n --ignore=vendor --runtime-set installed_paths vendor/wp-coding-standards/wpcs --standard=WordPress --report=checkstyle $GITHUB_WORKSPACE/tmp.php $(echo $CHANGED_FILES) | cs2pr
vendor/bin/phpcs -q -n --ignore=vendor --standard=WordPress --report=checkstyle $GITHUB_WORKSPACE/tmp.php $(echo $CHANGED_FILES) | cs2pr
2 changes: 1 addition & 1 deletion assets/js/shibboleth_login_form.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

jQuery( document ).ready(
function( $ ) {
function ( $ ) {
var body = $( 'body' ),
userLogin = $( '#user_login' ),
ssoWrap = $( '#shibboleth-wrap' ),
Expand Down
5 changes: 5 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,10 @@
"require": {},
"require-dev" : {
"wp-coding-standards/wpcs": "@stable"
},
"config": {
"allow-plugins": {
"dealerdirect/phpcodesniffer-composer-installer": true
}
}
}
Loading

0 comments on commit e4dc73f

Please sign in to comment.