fix: backchannel logout react to session ID (simpler approach)#1
Open
michaelstingl wants to merge 1 commit intomainfrom
Open
fix: backchannel logout react to session ID (simpler approach)#1michaelstingl wants to merge 1 commit intomainfrom
michaelstingl wants to merge 1 commit intomainfrom
Conversation
Read session ID from OIDC user profile internally in UserManager instead of threading it through updateContext/signInCallback call chain. This avoids signature changes, keeps the embed API stable, and reduces the change surface. The SSE backchannel logout handler now compares the event's session ID against the stored session to only log out the affected client, per the OIDC Back-Channel Logout spec. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Label error. Requires at least 1 of: Type:Bug, Type:Enhancement, Type:Feature, Type:Breaking-Change, Type:Test, Type:Documentation, Type:Maintenance, Type:Security, Type:Dependencies, Type:DevOps, dependencies. Found: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternative, simpler approach to opencloud-eu/web#1969 for backchannel logout session ID matching.
Key difference: Instead of threading
sessionIdthrough theupdateContext()/signInCallback()call chain (which forces signature changes across 13 files), this reads the session ID directly from the OIDC user profile insideUserManager.Comparison
updateContextsignaturesignInCallbacksignaturepostMessage)accesssTokentypo buggetSessionId())How it works
UserManager.updateContext()readsuser.profile.sidfrom the stored OIDC user internally — no parameter neededauthStore(Pinia)sessionidagainst stored sessionsessionidin event → log out all clients (per OIDC Back-Channel Logout spec)sessionid→ log out this client onlyFiles changed
auth.ts— AddsessionIdstate to Pinia auth storeuserManager.ts— Readsidfrom OIDC profile internally (no signature change)types.ts— Addsessionidto SSE event schema,AuthStoreto SSE optionscommon.ts— Backchannel logout logic (session ID comparison)bootstrap.ts+index.ts— PassauthStoreto SSE event listenersauthStoreto test mocksIssues found in PR opencloud-eu#1969
event.data.accesssToken(3× "s") inauthService.ts:384— would beundefinedat runtimegetSessionId()method added toUserManagerbut never calledhandleDelegatedTokenUpdatechangesevent.datafrom string to object🤖 Generated with Claude Code