-
Notifications
You must be signed in to change notification settings - Fork 3
Implement missing swiftfindrefs --version
#7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thanks @Nikoloutsos ❤️ ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we read the version using this https://github.com/michaelversus/SwiftFindRefs/blob/master/VERSION?
We have a workflow for the releases and it will be very convenient having this as single source of truth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, sure I can try it out. Better for the version to be in 1 place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up, VERSION has been moved inside Sources to be able to be copied from bundle (5a96132)
Also all scripts pointing to old path have been renewed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
==========================================
- Coverage 93.61% 93.59% -0.03%
==========================================
Files 32 33 +1
Lines 2052 2060 +8
==========================================
+ Hits 1921 1928 +7
- Misses 131 132 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| struct SwiftFindRefsTests { | ||
| @Test | ||
| func `Verify CLI version`() { | ||
| #expect(SwiftFindRefs.configuration.version == "1.0.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
By merging this PR we will be able to use
swiftfindrefs --version.current behavior is the following
This is a simple but important addition that will help with debugging especially when users report issues, knowing the exact version.