Skip to content

Conversation

@ascirpus
Copy link

@ascirpus ascirpus commented Jun 14, 2016

There's an issue with sendContent and run methods.
run method will traverse the array of decorators and apply each of them regardless of whether there's something to decorate at the moment within content.
If you have multiple decorators that depend one on another and one must be called after another then priority matters. In the current implementation some replacements will simply be ignored if there's nothing to replace at the moment.
This PR aims to fix that by adding a verification whether a replacement has been made and if so - reset the array and iterate through it again.

@michalcarson
Copy link
Owner

This looks interesting; thanks for taking the time to do a pull request.

I'm very interested to see the use case for this. Could you add a new paragraph to the readme.md to describe the usage of your code and provide an example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants