feat: add correction and system exports to ntps module#28
Merged
michealroberts merged 1 commit intomainfrom May 28, 2025
Merged
feat: add correction and system exports to ntps module#28michealroberts merged 1 commit intomainfrom
michealroberts merged 1 commit intomainfrom
Conversation
feat: add correction and system exports to ntps module
There was a problem hiding this comment.
Pull Request Overview
This PR exposes two new functions—get_ntp_offset_correction and set_system_time—in the ntps module and updates the public API list.
- Export
get_ntp_offset_correctionfrom thecorrectionsubmodule - Export
set_system_timefrom thesystemsubmodule - Update the
__all__list to include the new exports
Comments suppressed due to low confidence (1)
src/ntps/init.py:13
- Add or update unit tests to cover the new
set_system_timefunction, including edge cases (e.g., permission errors or invalid time values).
from .system import NTP_TIMESTAMP_DELTA, get_ntp_time, set_system_time
| # ************************************************************************************** | ||
|
|
||
| from .client import NTPClient | ||
| from .correction import get_ntp_offset_correction |
There was a problem hiding this comment.
[nitpick] Consider updating the module-level docstring or README to document the new get_ntp_offset_correction export so consumers understand its purpose and usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add correction and system exports to ntps module