feat: send originate_timestamp in NTPClient query in ntps module#32
Merged
michealroberts merged 1 commit intomainfrom May 28, 2025
Merged
Conversation
feat: send originate_timestamp in NTPClient query in ntps module
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to include the originate_timestamp in the NTP client request packet.
- Refactors the request packet creation to use a mutable bytearray
- Computes and packs the originate_timestamp high/low values into the correct byte positions
Comments suppressed due to low confidence (1)
src/ntps/client.py:64
- Ensure that the new originate_timestamp logic is covered by unit tests to verify that the high and low parts are correctly calculated and packed.
now = time() + NTP_TIMESTAMP_DELTA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: send originate_timestamp in NTPClient query in ntps module