dont mutate args object

mickhansen · Feb 25, 2018 · bdd8def · bdd8def
1 parent 1d708b7
commit bdd8def
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/src/relay.js b/src/relay.js
@@ -217,15 +217,12 @@ export function sequelizeConnection({
       if (args.first || args.last) {
         options.limit = parseInt(args.first || args.last, 10);
       }
-      if (!args.orderBy) {
-        args.orderBy = [
-          [model.primaryKeyAttribute, 'ASC']
-        ];
-      } else if (orderByEnum && typeof args.orderBy === 'string') {
-        args.orderBy = [orderByEnum._nameLookup[args.orderBy].value];
+
+      let orderBy = args.orderBy || [[model.primaryKeyAttribute, 'ASC']];
+      if (orderByEnum && typeof orderBy === 'string') {
+        orderBy = [orderByEnum._nameLookup[args.orderBy].value];
       }
 
-      let orderBy = args.orderBy;
       let orderAttribute = orderByAttribute(orderBy[0][0], {
         source: info.source,
         args,