Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype addition of an editable yaml file for ease of use in extracting ENVO terms via OAK for env triad permissible values #8

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

sierra-moxon
Copy link
Member

@sierra-moxon sierra-moxon commented Aug 30, 2024

this PR tries to:

  • add a simple yaml file that team members could edit to control the generation of a list of terms from ENVO extracted via OAK (prototyped one replacement makefile target - still work to do to replace broad_scale targets, etc.)
    • and subsequently, use oak via Python instead of wrapping the command-line function
  • add tests of the oak extraction and file generation steps
  • make the generation runnable from a make command
  • separate the config of the ENVO adapter from the config of the terms to extract
  • start pulling apart the Makefile into modules
    • should we pull our final control logic (makefile), scripts, extraction logic, and config files into a repo that only has the job of producing these value sets? I think that would help us maintain this logic in "production" mode.

Copy link
Member

@turbomam turbomam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I have added another env_local_set tweaking mechanism since we last met. Can we meet on Zoom to make sure everything is compatible and then do the merge?

config/env-local-scale-extraction-config.yaml Outdated Show resolved Hide resolved
@turbomam
Copy link
Member

PS I'll be push some more soon, but in a branch, not main

@sierra-moxon sierra-moxon requested a review from turbomam August 30, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants