Implement display.rotate(degrees) method.#220
Merged
Conversation
Signed-off-by: Damien George <damien@micropython.org>
Collaborator
Author
|
@microbit-carlos does it make sense to accept floating point values as well, in case the user is using a formula to compute the angle? |
Closed
Contributor
|
Thanks Damien!
Yes, accepting floats as well would be useful. |
This takes an angle in degrees and rounds it towards the nearest multiple of 90. Signed-off-by: Damien George <damien@micropython.org>
dpgeorge
force-pushed
the
display-rotate
branch
from
74e32fb to
ff39fbf
Compare
Collaborator
Author
|
Updated to accept floats as input rotation angle. |
microbit-carlos
approved these changes
Sep 15, 2024
Contributor
microbit-carlos
left a comment
microbit-carlos
left a comment
There was a problem hiding this comment.
Tested and looks great, thanks Damien!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes an angle in degrees and rounds it towards the nearest multiple of 90. All integer values of degrees are accepted, including negative values.
Eg
display.rotate(44)will rotate 0 butdisplay.rotate(46)will rotate 90 degrees.Addresses issue #153.