Open shared makecode project #614
Draft
+1,823
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to think about the URL handling. The key thing is that after the user has imported the project they no longer have the URL with the id in their history. So we need to do a replaceState-style URL update at some point. Otherwise you go back and start an import process again which isn't helpful. |
glastonbridge
force-pushed
the
open-shared-makecode-project
branch
from
950e839 to
dcca968
Compare
| element: <CodePage />, | ||
| }, | ||
| { | ||
| path: createImportSharedURLPageUrl(), |
There was a problem hiding this comment.
We missed this rename. Needs to be createOpenSharedProjectPageUrl() now.
| @@ -0,0 +1,51 @@ | |||
| /** | |||
There was a problem hiding this comment.
e2e file names also need aligning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently set up to open a shared project if the URL path
For instance, running on localhost, this link should load a project with some samples: http://localhost:5173/_fDpWJaY67cgR
https://review-createai.microbit.org/open-shared-makecode-project/_fDpWJaY67cgR
Once loaded, the UI shows you a preview.
Note that this differs slightly from the Miro board, as some of the design leans on styling from Microbit Classroom, e.g. this page.
If there is an error while trying to fetch the preview, you will see
TODO: needs an e2e test.