Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First translation sync #31

Merged
merged 15 commits into from
Jan 3, 2025
Merged

First translation sync #31

merged 15 commits into from
Jan 3, 2025

Conversation

microbit-grace
Copy link
Contributor

@microbit-grace microbit-grace commented Jan 2, 2025 •
edited by microbit-matt-hillsdon
Loading

  • Added translation files for es-es, ja, ko, nl, pl, pt-BR, and zh-TW
  • Added update-translation scripts for sim and extension

Made some manual minor fixes in certain translation files for now to get things to compile

Limitations:

  • Japanese lacks translation for the more recent docs
  • We only just corrected the source text for the title of the certainty block help file so that's not yet translated

@microbit-grace microbit-grace changed the title [WIP-DO NOT MERGE] Translations [DO NOT MERGE] First cut on translations Jan 3, 2025
@microbit-grace microbit-grace changed the title [DO NOT MERGE] First cut on translations First translation sync Jan 3, 2025
@microbit-grace microbit-grace marked this pull request as ready for review January 3, 2025 13:59
@microbit-grace microbit-grace requested a review from a team January 3, 2025 13:59
@microbit-grace microbit-grace requested a review from a team January 3, 2025 15:21
@microbit-grace microbit-grace mentioned this pull request Jan 3, 2025
Merged
microbit-matt-hillsdon
microbit-matt-hillsdon approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks. I added some limitations notes to the PR comment.

@microbit-grace microbit-grace merged commit 217a1a6 into main Jan 3, 2025
2 checks passed
@microbit-grace microbit-grace deleted the translations branch January 3, 2025 15:50
microbit-matt-hillsdon pushed a commit to microbit-foundation/ml-trainer that referenced this pull request Jan 7, 2025
@microbit-grace
First translation sync (#576)
d8952da 
- Adds translation files for CreateAI. All languages are a preview for now and will not show on live.
- Sync language from tool to embedded MakeCode. Currently, changing language inside MakeCode does not work.
- Updates extension version to also support translations. (microbit-foundation/pxt-microbit-ml#31)
- Adds a link to ask for more support in translation in Language dialog. (microbit-foundation/ml-trainer-microbit#16 (private))
- Script for adding machine-learning-strings.json to ui.en.json for MakeCode default code view.
- Handle different translations and text length for default code view blocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microbit-robert microbit-robert microbit-robert left review comments

@microbit-matt-hillsdon microbit-matt-hillsdon microbit-matt-hillsdon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@microbit-grace @microbit-matt-hillsdon @microbit-robert