Skip to content

Commit

Permalink
MPAE-7842 Fixing review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Martin-MCHP committed Oct 21, 2020
1 parent cee58fb commit e67a8bd
Show file tree
Hide file tree
Showing 16 changed files with 19 additions and 558 deletions.
4 changes: 2 additions & 2 deletions .main-meta/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
"metaDataVersion": "1.1.0",
"name": "com.microchip.mcu8.studio.project.avr128db48-training-on-opamp-xoschf-mvio-studio",
"version": "1.0.0",
"displayName": "Training on OPAMP, XOSCHF and MVIO",
"displayName": "AVR DB training on OPAMP, XOSCHF and MVIO",
"projectName": "avr128db48-training-on-opamp-xoschf-mvio-studio",
"shortDescription": "These Atmel Studio 7 examples in Training on OPAMP, XOSCHF and MVIO Atmel Studio, show how the OPAMP, XOSCHF and MVIO peripherals can be used on the AVR DB family of microcontrollers.",
"shortDescription": "Atmel Studio 7 training code examples for the AVR DB family of microcontrollers, demonstrating use of the OPAMP, XOSCHF and MVIO peripherals.",
"ide": {
"name": "Studio",
"semverRange": ">=7.0.2397"
Expand Down
6 changes: 0 additions & 6 deletions Assignment2/Assignment2/nbproject/private/private.xml

This file was deleted.

2 changes: 0 additions & 2 deletions Assignment3/Assignment3/Assignment3.cproj
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
</avrgcc.linker.libraries.Libraries>
<avrgcc.assembler.general.IncludePaths>
<ListValues>
<Value>%24(PackRepoDir)\Atmel\AVR-DB_DFP\1.0.21\include</Value>
<Value>%24(PackRepoDir)\Atmel\AVR-Dx_DFP\1.4.73\include\</Value>
</ListValues>
</avrgcc.assembler.general.IncludePaths>
Expand Down Expand Up @@ -117,7 +116,6 @@
</avrgcc.linker.libraries.Libraries>
<avrgcc.assembler.general.IncludePaths>
<ListValues>
<Value>%24(PackRepoDir)\Atmel\AVR-DB_DFP\1.0.21\include</Value>
<Value>%24(PackRepoDir)\Atmel\AVR-Dx_DFP\1.4.73\include\</Value>
</ListValues>
</avrgcc.assembler.general.IncludePaths>
Expand Down
6 changes: 0 additions & 6 deletions Assignment3/Assignment3/nbproject/private/private.xml

This file was deleted.

2 changes: 1 addition & 1 deletion DataVisualizer/Assignment4.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"scheme":2,"settings":{"chart":{"panels":{"primary-graph":{"cursors":["0ab90de2-039e-4448-ae60-26b681271b90","17e1e5f4-a327-403a-bab6-67a99550b915"],"trackSizes":{"vertical":[],"horizontal":[]}}},"axisProps":{"01ac7941-a5e7-46fd-ab15-411719569eca":{"panelId":"primary-graph","active":false,"offset":0,"scale":776,"type":"data"},"df84fd6c-5a67-4a92-815f-e21d2cb98942":{"panelId":"primary-graph","active":false,"offset":0,"scale":776,"type":"data"},"primary-graph":{"panelId":"primary-graph","active":false,"offset":6120.506505143239,"scale":0.11841535675921477,"type":"time"}},"axisPositions":{"01ac7941-a5e7-46fd-ab15-411719569eca":{"panelId":"primary-graph","orientation":"vertical","alignment":"before","track":0,"order":0},"df84fd6c-5a67-4a92-815f-e21d2cb98942":{"panelId":"primary-graph","orientation":"vertical","alignment":"before","track":0,"order":0},"primary-graph":{"panelId":"primary-graph","orientation":"horizontal","alignment":"after","track":0,"order":0}},"plotProps":{"8e18288e-418d-4bd5-a325-4f46292097d4":{"panelId":"primary-graph","sourceId":"decoder-e8151bb0-5973-11ea-907c-eb810a612336$Waveform Generator (DAC)","color":"#f44e3b","lineMode":"linear"},"552e5a74-8e29-4a0a-a874-1a02f83ff62c":{"panelId":"primary-graph","sourceId":"decoder-e8151bb0-5973-11ea-907c-eb810a612336$Non Inverting PGA (OPAMP)","color":"#a4dd00","lineMode":"linear"}},"plotPositions":{"8e18288e-418d-4bd5-a325-4f46292097d4":{"panelId":"primary-graph","hAxes":[],"vAxes":["01ac7941-a5e7-46fd-ab15-411719569eca"]},"552e5a74-8e29-4a0a-a874-1a02f83ff62c":{"panelId":"primary-graph","hAxes":[],"vAxes":["df84fd6c-5a67-4a92-815f-e21d2cb98942"]}},"cursorProps":{"0ab90de2-039e-4448-ae60-26b681271b90":{"panelId":"primary-graph","tag":"A","anchor":"domain","color":"#00F","offset":2577.4138224912617},"17e1e5f4-a327-403a-bab6-67a99550b915":{"panelId":"primary-graph","tag":"B","anchor":"domain","color":"#00F","offset":2577.433860545186}},"inspector":{"enabled":true,"yPosition":30},"activeDataAxisId":"df84fd6c-5a67-4a92-815f-e21d2cb98942","prevColorChoiceIndex":-1},"terminal":{"sourceId":"","characterSet":"hex","filterControlChars":false,"hexMode":false,"echo":true,"lineEnd":"\r\n","terminalDirty":false},"ui":{"sidebars":{"left.sidebar":{"id":"left.sidebar","visible":true},"right.sidebar":{"id":"right.sidebar","visible":true}},"panels":{"connections.panel":{"id":"connections.panel","open":true},"connection.options.panel":{"id":"connection.options.panel","open":true}},"dialogs":[],"darkTheme":true,"devMode":false},"sourceSettings":{"byId":{"COM27":{"id":"COM27","formValues":{"baudRate":115200,"charLength":8,"stopBits":0,"parity":0,"invalid":-1}},"COM10":{"id":"COM10","formValues":{"baudRate":115200,"charLength":8,"stopBits":0,"parity":0,"invalid":-1}}}},"protocolShapes":{"byId":{"":{"fields":[{"id":"$Waveform Generator (DAC)","name":"Waveform Generator (DAC)","type":4,"offset":0},{"id":"$Non Inverting PGA (OPAMP)","name":"Non Inverting PGA (OPAMP)","type":4,"offset":2}],"id":"","name":"Decoder 1","frame":{"mode":{"label":"Auto","id":"auto"},"startOfFrame":0}}}},"protocols":{"byId":{"decoder-e8151bb0-5973-11ea-907c-eb810a612336":{"fields":[{"id":"$Waveform Generator (DAC)","name":"Waveform Generator (DAC)","offset":0,"type":4},{"id":"$Non Inverting PGA (OPAMP)","name":"Non Inverting PGA (OPAMP)","offset":2,"type":4}],"frame":{"mode":"auto","startOfFrame":0},"id":"decoder-e8151bb0-5973-11ea-907c-eb810a612336","name":"Decoder 1","outputs":["decoder-e8151bb0-5973-11ea-907c-eb810a612336$Waveform Generator (DAC)","decoder-e8151bb0-5973-11ea-907c-eb810a612336$Non Inverting PGA (OPAMP)"]}},"shapeSelection":{"decoder-e8151bb0-5973-11ea-907c-eb810a612336":""},"statisticsById":{"decoder-e8151bb0-5973-11ea-907c-eb810a612336":{"discardedByteCount":4,"decodedFrameCount":5548,"decodeRate":804,"hasProtocolMismatch":false}}},"links":{"byId":{"014a3fe0-03d6-11eb-a036-770604a8eb49":{"sourceId":"COM13","sinkId":"decoder-e8151bb0-5973-11ea-907c-eb810a612336"}}}}}
{"scheme":2,"settings":{"chart":{"panels":{"primary-graph":{"cursors":["0ab90de2-039e-4448-ae60-26b681271b90","17e1e5f4-a327-403a-bab6-67a99550b915"],"trackSizes":{"vertical":[],"horizontal":[]}}},"axisProps":{"01ac7941-a5e7-46fd-ab15-411719569eca":{"panelId":"primary-graph","active":false,"offset":0,"scale":776,"type":"data"},"df84fd6c-5a67-4a92-815f-e21d2cb98942":{"panelId":"primary-graph","active":false,"offset":0,"scale":776,"type":"data"},"primary-graph":{"panelId":"primary-graph","active":false,"offset":95.541144543241,"scale":0.11841535675921477,"type":"time"}},"axisPositions":{"01ac7941-a5e7-46fd-ab15-411719569eca":{"panelId":"primary-graph","orientation":"vertical","alignment":"before","track":0,"order":0},"df84fd6c-5a67-4a92-815f-e21d2cb98942":{"panelId":"primary-graph","orientation":"vertical","alignment":"before","track":0,"order":0},"primary-graph":{"panelId":"primary-graph","orientation":"horizontal","alignment":"after","track":0,"order":0}},"plotProps":{"8e18288e-418d-4bd5-a325-4f46292097d4":{"panelId":"primary-graph","sourceId":"decoder-e8151bb0-5973-11ea-907c-eb810a612336$Waveform Generator (DAC)","color":"#f44e3b","lineMode":"linear"},"552e5a74-8e29-4a0a-a874-1a02f83ff62c":{"panelId":"primary-graph","sourceId":"decoder-e8151bb0-5973-11ea-907c-eb810a612336$Non Inverting PGA (OPAMP)","color":"#a4dd00","lineMode":"linear"}},"plotPositions":{"8e18288e-418d-4bd5-a325-4f46292097d4":{"panelId":"primary-graph","hAxes":[],"vAxes":["01ac7941-a5e7-46fd-ab15-411719569eca"]},"552e5a74-8e29-4a0a-a874-1a02f83ff62c":{"panelId":"primary-graph","hAxes":[],"vAxes":["df84fd6c-5a67-4a92-815f-e21d2cb98942"]}},"cursorProps":{"0ab90de2-039e-4448-ae60-26b681271b90":{"panelId":"primary-graph","tag":"A","anchor":"domain","color":"#00F","offset":2577.4138224912617},"17e1e5f4-a327-403a-bab6-67a99550b915":{"panelId":"primary-graph","tag":"B","anchor":"domain","color":"#00F","offset":2577.433860545186}},"inspector":{"enabled":true,"yPosition":30},"activeDataAxisId":"df84fd6c-5a67-4a92-815f-e21d2cb98942","prevColorChoiceIndex":-1},"terminal":{"sourceId":"","characterSet":"hex","filterControlChars":false,"hexMode":false,"echo":true,"lineEnd":"\r\n","terminalDirty":false},"ui":{"sidebars":{"left.sidebar":{"id":"left.sidebar","visible":true},"right.sidebar":{"id":"right.sidebar","visible":true}},"panels":{"connections.panel":{"id":"connections.panel","open":true},"connection.options.panel":{"id":"connection.options.panel","open":true}},"dialogs":[],"darkTheme":true,"devMode":false},"sourceSettings":{"byId":{"COM27":{"id":"COM27","formValues":{"baudRate":115200,"charLength":8,"stopBits":0,"parity":0,"invalid":-1}},"COM10":{"id":"COM10","formValues":{"baudRate":115200,"charLength":8,"stopBits":0,"parity":0,"invalid":-1}},"COM13":{"id":"COM13","formValues":{"baudRate":115200,"charLength":8,"stopBits":0,"parity":0,"invalid":-1}}}},"protocolShapes":{"byId":{"":{"fields":[{"id":"$Waveform Generator (DAC)","name":"Waveform Generator (DAC)","type":4,"offset":0},{"id":"$Non Inverting PGA (OPAMP)","name":"Non Inverting PGA (OPAMP)","type":4,"offset":2}],"id":"","name":"Decoder 1","frame":{"mode":{"label":"Auto","id":"auto"},"startOfFrame":0}}}},"protocols":{"byId":{"decoder-e8151bb0-5973-11ea-907c-eb810a612336":{"fields":[{"id":"$Waveform Generator (DAC)","name":"Waveform Generator (DAC)","offset":0,"type":4},{"id":"$Non Inverting PGA (OPAMP)","name":"Non Inverting PGA (OPAMP)","offset":2,"type":4}],"frame":{"mode":"auto","startOfFrame":0},"id":"decoder-e8151bb0-5973-11ea-907c-eb810a612336","name":"Decoder 1","outputs":["decoder-e8151bb0-5973-11ea-907c-eb810a612336$Waveform Generator (DAC)","decoder-e8151bb0-5973-11ea-907c-eb810a612336$Non Inverting PGA (OPAMP)"]}},"shapeSelection":{"decoder-e8151bb0-5973-11ea-907c-eb810a612336":""},"statisticsById":{"decoder-e8151bb0-5973-11ea-907c-eb810a612336":{"discardedByteCount":2,"decodedFrameCount":36349,"decodeRate":800.7968,"hasProtocolMismatch":false}}},"links":{"byId":{"014a3fe0-03d6-11eb-a036-770604a8eb49":{"sourceId":"COM13","sinkId":"decoder-e8151bb0-5973-11ea-907c-eb810a612336"}}}}}
2 changes: 1 addition & 1 deletion DataVisualizer/Assignment5.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"scheme":2,"settings":{"chart":{"panels":{"primary-graph":{"cursors":[],"trackSizes":{"vertical":[],"horizontal":[]}}},"axisProps":{"01ac7941-a5e7-46fd-ab15-411719569eca":{"panelId":"primary-graph","active":false,"offset":0,"scale":3300,"type":"data"},"df84fd6c-5a67-4a92-815f-e21d2cb98942":{"panelId":"primary-graph","active":false,"offset":0,"scale":3300,"type":"data"},"primary-graph":{"panelId":"primary-graph","active":false,"offset":158.00395184896996,"scale":0.2720470510312225,"type":"time"}},"axisPositions":{"01ac7941-a5e7-46fd-ab15-411719569eca":{"panelId":"primary-graph","orientation":"vertical","alignment":"before","track":0,"order":0},"df84fd6c-5a67-4a92-815f-e21d2cb98942":{"panelId":"primary-graph","orientation":"vertical","alignment":"before","track":0,"order":0},"primary-graph":{"panelId":"primary-graph","orientation":"horizontal","alignment":"after","track":0,"order":0}},"plotProps":{"8e18288e-418d-4bd5-a325-4f46292097d4":{"panelId":"primary-graph","sourceId":"decoder-e8151bb0-5973-11ea-907c-eb810a612336$Differential Input","color":"#f44e3b","lineMode":"linear"},"552e5a74-8e29-4a0a-a874-1a02f83ff62c":{"panelId":"primary-graph","sourceId":"decoder-e8151bb0-5973-11ea-907c-eb810a612336$Instrumentation Amplifier (OUT)","color":"#a4dd00","lineMode":"linear"}},"plotPositions":{"8e18288e-418d-4bd5-a325-4f46292097d4":{"panelId":"primary-graph","hAxes":[],"vAxes":["01ac7941-a5e7-46fd-ab15-411719569eca"]},"552e5a74-8e29-4a0a-a874-1a02f83ff62c":{"panelId":"primary-graph","hAxes":[],"vAxes":["df84fd6c-5a67-4a92-815f-e21d2cb98942"]}},"cursorProps":{},"inspector":{"enabled":true,"yPosition":30},"activeDataAxisId":"01ac7941-a5e7-46fd-ab15-411719569eca","prevColorChoiceIndex":-1},"terminal":{"sourceId":"","characterSet":"hex","filterControlChars":false,"hexMode":false,"echo":true,"lineEnd":"\r\n","terminalDirty":false},"ui":{"sidebars":{"left.sidebar":{"id":"left.sidebar","visible":true},"right.sidebar":{"id":"right.sidebar","visible":true}},"panels":{"connections.panel":{"id":"connections.panel","open":true},"connection.options.panel":{"id":"connection.options.panel","open":true}},"dialogs":[],"darkTheme":true,"devMode":false},"sourceSettings":{"byId":{"COM27":{"id":"COM27","formValues":{"baudRate":115200,"charLength":8,"stopBits":0,"parity":0,"invalid":-1}},"COM10":{"id":"COM10","formValues":{"baudRate":115200,"charLength":8,"stopBits":0,"parity":0,"invalid":-1}}}},"protocolShapes":{"byId":{"":{"fields":[{"id":"$Differential Input","name":"Differential Input","type":4,"offset":0},{"id":"$Instrumentation Amplifier (OUT)","name":"Instrumentation Amplifier (OUT)","type":4,"offset":2}],"id":"","name":"Decoder 1","frame":{"mode":{"label":"Auto","id":"auto"},"startOfFrame":0}}}},"protocols":{"byId":{"decoder-e8151bb0-5973-11ea-907c-eb810a612336":{"fields":[{"id":"$Differential Input","name":"Differential Input","offset":0,"type":4},{"id":"$Instrumentation Amplifier (OUT)","name":"Instrumentation Amplifier (OUT)","offset":2,"type":4}],"frame":{"mode":"auto","startOfFrame":0},"id":"decoder-e8151bb0-5973-11ea-907c-eb810a612336","name":"Decoder 1","outputs":["decoder-e8151bb0-5973-11ea-907c-eb810a612336$Instrumentation Amplifier (OUT)","decoder-e8151bb0-5973-11ea-907c-eb810a612336$Differential Input"]}},"shapeSelection":{"decoder-e8151bb0-5973-11ea-907c-eb810a612336":""},"statisticsById":{"decoder-e8151bb0-5973-11ea-907c-eb810a612336":{"discardedByteCount":0,"decodedFrameCount":4781,"decodeRate":804,"hasProtocolMismatch":false}}},"links":{"byId":{"7ef433b0-03d6-11eb-80a9-bdad7d40afda":{"sourceId":"COM13","sinkId":"decoder-e8151bb0-5973-11ea-907c-eb810a612336"}}}}}
{"scheme":2,"settings":{"chart":{"panels":{"primary-graph":{"cursors":[],"trackSizes":{"horizontal":[],"vertical":[]}}},"axisProps":{"primary-graph":{"panelId":"primary-graph","type":"time","scale":0.9473228540737182,"offset":287.12243704592674,"active":false},"fc5a8758-3bfc-4585-9e32-a4b64590fb13":{"panelId":"primary-graph","type":"data","scale":1891.646540884072,"offset":45.30464460411349,"active":false}},"axisPositions":{"primary-graph":{"panelId":"primary-graph","orientation":"horizontal","track":0,"alignment":"after","order":0},"fc5a8758-3bfc-4585-9e32-a4b64590fb13":{"panelId":"primary-graph","orientation":"vertical","track":0,"alignment":"before","order":0}},"plotProps":{"4d126cd4-cf24-4ce7-a4a2-8861db8e1f1d":{"panelId":"primary-graph","sourceId":"decoder-75d76d50-fd8d-11ea-8781-4bf2a9320c30$VADDIO2","lineMode":"steps","color":"#009ce0"}},"plotPositions":{"4d126cd4-cf24-4ce7-a4a2-8861db8e1f1d":{"panelId":"primary-graph","hAxes":[],"vAxes":["fc5a8758-3bfc-4585-9e32-a4b64590fb13"]}},"cursorProps":{},"inspector":{"enabled":true,"yPosition":30},"activeDataAxisId":"fc5a8758-3bfc-4585-9e32-a4b64590fb13","prevColorChoiceIndex":1},"terminal":{"characterSet":"iso-8859-1","filterControlChars":false,"hexMode":false,"echo":true,"lineEnd":"\r\n","terminalDirty":false},"ui":{"sidebars":{"left.sidebar":{"id":"left.sidebar","visible":true},"right.sidebar":{"id":"right.sidebar","visible":true}},"panels":{"connections.panel":{"id":"connections.panel","open":true},"connection.options.panel":{"id":"connection.options.panel","open":true}},"dialogs":[],"darkTheme":true,"devMode":false},"sourceSettings":{"byId":{"COM13":{"id":"COM13","formValues":{"baudRate":115200,"charLength":8,"stopBits":0,"parity":0,"invalid":-1}},"1003-8565-mchp3372021800000244-GPIO":{"id":"1003-8565-mchp3372021800000244-GPIO","formValues":{"gpio-1-monitored":1,"fill-gpio-points":1,"timestamp":1,"gpio-0-monitored":0}}}},"protocolShapes":{"byId":{"12":{"fields":[{"id":"12$VADDIO2","name":"VADDIO2","type":4,"offset":0}],"id":"12","name":"VDDIO2","frame":{"mode":{"label":"Auto","id":"auto"},"startOfFrame":0}}}},"protocols":{"byId":{"decoder-75d76d50-fd8d-11ea-8781-4bf2a9320c30":{"fields":[{"id":"$VADDIO2","name":"VADDIO2","offset":0,"type":4}],"frame":{"mode":"auto","startOfFrame":0},"id":"decoder-75d76d50-fd8d-11ea-8781-4bf2a9320c30","name":"VDDIO2","outputs":["decoder-75d76d50-fd8d-11ea-8781-4bf2a9320c30$VADDIO2"]}},"shapeSelection":{"decoder-75d76d50-fd8d-11ea-8781-4bf2a9320c30":"12"},"statisticsById":{"decoder-75d76d50-fd8d-11ea-8781-4bf2a9320c30":{"discardedByteCount":5,"decodedFrameCount":253124,"decodeRate":2406.3745,"hasProtocolMismatch":false}}},"links":{"byId":{"7751ff60-fd8d-11ea-8781-4bf2a9320c30":{"sourceId":"COM13","sinkId":"decoder-75d76d50-fd8d-11ea-8781-4bf2a9320c30"}}}}}
Loading

0 comments on commit e67a8bd

Please sign in to comment.