Merge pull request #714 from microlinkhq/next

fix(x): strip query parameter from title
microlinkhq · Jun 30, 2024 · 6f4db22 · 6f4db22
2 parents 85d3621 + 9fcf3d7
commit 6f4db22
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/packages/metascraper-x/src/index.js b/packages/metascraper-x/src/index.js
@@ -30,7 +30,11 @@ module.exports = ({ resolveUrls = false, resolveUrl = url => url } = {}) => {
         return author?.includes(' on X') ? author.split(' on X')[0] : author
       })
     ],
-    title: [toTitle(($, url) => `@${url.split('/')[3]} on X`)],
+    title: [
+      toTitle(
+        ($, url) => `@${new URL(url).pathname.toString().split('/')[1]} on X`
+      )
+    ],
     url: [
       toUrl($ =>
         $('link[rel="canonical"]').attr('href')?.replace('twitter.com', 'x.com')

diff --git a/packages/metascraper-x/test/index.js b/packages/metascraper-x/test/index.js
@@ -21,7 +21,7 @@ const createMetascraper = (...args) =>
   ])
 
 test('from a X profile', async t => {
-  const url = 'https://x.com/Kikobeats'
+  const url = 'https://x.com/kikobeats?mx=2'
   const html = await readFile(resolve(__dirname, 'fixtures/profile.html'))
   const metascraper = createMetascraper()
   const metadata = await metascraper({ url, html })

diff --git a/packages/metascraper-x/test/snapshots/index.js.md b/packages/metascraper-x/test/snapshots/index.js.md
@@ -15,7 +15,7 @@ Generated by [AVA](https://avajs.dev).
       image: 'https://pbs.twimg.com/profile_images/1717583638991138816/4HvMeeps_400x400.jpg',
       lang: 'en',
       publisher: 'X',
-      title: '@Kikobeats on X',
+      title: '@kikobeats on X',
       url: 'https://x.com/Kikobeats',
       video: null,
     }

diff --git a/packages/metascraper-x/test/snapshots/index.js.snap b/packages/metascraper-x/test/snapshots/index.js.snap