feat: allow passing htmlDom
#711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows customizing the parser (using htmlparser2 instead of default's more strict and slower parse5). Also, if you do any post-processing, you can reuse the object and avoid parsing twice (expensive)
Kikobeats
reviewed
Jun 24, 2024
packages/metascraper/src/index.js
Outdated
| @@ -14,6 +14,7 @@ module.exports = rules => { | |||
| return async ({ | |||
| url, | |||
| html = '', | |||
| dom, | |||
There was a problem hiding this comment.
What do you think rename it into htmlDom?
That's is how it's passed down
Kikobeats
changed the title
htmlDom
|
Thanks for this! Whe you pass const { load } = require('cheerio')
const htmlDom = load(html, { baseURI: url }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows customizing the parser (using htmlparser2 instead of default's more strict and slower parse5). Also, if you do any post-processing, you can reuse the object and avoid parsing twice (expensive)