Update for MP6 #494

majidmostafavi · 2024-01-15T17:41:52Z

Add Telemetry
update for MP6

Remove Open Tracing Add Telemetry

majidmostafavi · 2024-02-19T20:17:16Z

@Emily-Jiang
I find the error @health is deprecated. so I should replace it by @Liveness ,@readiness.

Emily-Jiang · 2024-02-19T23:27:29Z

@Emily-Jiang I find the error @health is deprecated. so I should replace it by @Liveness ,@readiness.

Depending on which version of MP health you are talking about. It was only deprecated later. It was fine in the earlier version of MP Health. I suggest you to fix the test error first not to change other things.

Emily-Jiang · 2024-03-25T17:40:35Z

@luiseufrasio did you figure out what was the test failures and propose a update on the PR to unblock this?

luiseufrasio · 2024-04-03T10:15:04Z

clipsefdn/eca

@Emily-Jiang the tests seems to be NOT running: https://github.com/eclipse/microprofile-starter/pull/494/checks
I says "Workflow runs completed with no jobs"

Emily-Jiang · 2024-04-03T21:00:51Z

The conflict needs to be solved before the tests can be executed. @majidmostafavi can you please resolve the conflicts and then the CI jobs can be launched?

src/main/java/org/eclipse/microprofile/starter/rest/APIEndpointV7.java

…tV7.java

src/main/java/org/eclipse/microprofile/starter/rest/APIEndpointV7.java

…tV7.java

before MP50 and MP60 use Health

Emily-Jiang · 2024-04-15T22:02:39Z

src/test/resources/json_examples/v7/supportMatrix.json.segments

@@ -0,0 +1,4 @@
+{"configs":{"
+MP33":{"supportedServers":["
+]},"MP32":{"supportedServers":[


I am not sure this file. Do you need to just mention MP60?

@rdebusscher we are stuck on this failure. Can you please shed some lights on this? Your help is very much appreciated.

@Emily-Jiang What is the issue exactly? From the failed test run, it just seems a problem with some assertions on text values.
Not much time to go in detail for the moment.

I found the error in the surefire-reports and changed the code to print the URL call which fails: Download failed. URI: http://127.0.0.1:9090/api/project?supportedServer=LIBERTY&selectedSpecs=CONFIG&selectedSpecs=FAULT_TOLERANCE&selectedSpecs=HEALTH_CHECKS&selectedSpecs=METRICS&selectedSpecs=OPEN_TRACING&selectedSpecs=OPEN_API&artifactId=liberty&buildTool=MAVEN expected:<200> but was:<400>

I tried the URL locally running on liberty:

So after I called:
http://127.0.0.1:9080/mp-starter/api/project?supportedServer=LIBERTY&selectedSpecs=CONFIG&selectedSpecs=FAULT_TOLERANCE&selectedSpecs=HEALTH_CHECKS&selectedSpecs=METRICS&selectedSpecs=OPEN_TRACING&selectedSpecs=OPEN_API&artifactId=liberty&buildTool=MAVEN

I received back:

{ "error": "One or more selectedSpecs is not available for the given mpVersion", "code": "ERROR003" }

I am not sure the version combination.
What about the error for APITest?

Error in the API test is due to the addition of the Telemetry option. Please update the test to the new expected values.

Which file needs to be updated? @rdebusscher

Based on the log of the test

https://github.com/eclipse/microprofile-starter/pull/494/checks#step:7:17864

This is the failure

supportMatrix(org.eclipse.microprofile.starter.APITest) Time elapsed: 0.319 sec <<< FAILURE! java.lang.AssertionError: Response of /7/supportMatrix

And from the test method APITest#supportMatrix

public void supportMatrix() throws FileNotFoundException { test(v7Matrix, "/7/supportMatrix");

we see that the contents of this file os compared to the response

v7Matrix = new File(getClass().getClassLoader().getResource("json_examples/v7/supportMatrix.json.segments").getFile());

rdebusscher · 2024-04-20T13:08:45Z

Why is there a v7 of the Api created when it is identical to v6?

Emily-Jiang · 2024-04-20T21:08:08Z

Why is there a v7 of the Api created when it is identical to v6?

v7 has Telemetry added though.

rdebusscher · 2024-04-21T11:15:14Z

The version of the API has nothing to do with the config op the MP versions and the options. It is about the available endpoints, their parameters and responses.

So /api/mpVersion/MP60, /api/7/mpVersion/MP60, and , /api/6/mpVersion/MP60 all return

{"specs":["CONFIG","FAULT_TOLERANCE","JWT_AUTH","METRICS","HEALTH_CHECKS","OPEN_API","REST_CLIENT","TELEMETRY","GRAPHQL"],"supportedServers":["LIBERTY"]}

Even the API versions 2 and higher, all return this result which includes Telemetry.

So there is no need at all to have a new API version.

before MP50 and MP60 use Health

Emily-Jiang · 2024-04-29T16:26:10Z

The version of the API has nothing to do with the config op the MP versions and the options. It is about the available endpoints, their parameters and responses.

So /api/mpVersion/MP60, /api/7/mpVersion/MP60, and , /api/6/mpVersion/MP60 all return
{"specs":["CONFIG","FAULT_TOLERANCE","JWT_AUTH","METRICS","HEALTH_CHECKS","OPEN_API","REST_CLIENT","TELEMETRY","GRAPHQL"],"supportedServers":["LIBERTY"]}
Even the API versions 2 and higher, all return this result which includes Telemetry.

So there is no need at all to have a new API version.

I thought the earlier version of MP (1.x-5.x) should NOT return Telemetry @rdebusscher

rdebusscher · 2024-04-29T19:25:27Z

Earlier versions of MP will not return Telemetry. As I already said, MP Version and API version of the Starter app are 2 independent things.

Emily-Jiang · 2024-04-29T20:43:20Z

Earlier versions of MP will not return Telemetry. As I already said, MP Version and API version of the Starter app are 2 independent things.

Should the earlier API version such as 2.x return Telemetry at all?

rdebusscher · 2024-05-01T07:46:31Z

Earlier versions of MP will not return Telemetry. As I already said, MP Version and API version of the Starter app are 2 independent things.

Should the earlier API version such as 2.x return Telemetry at all?

In my opinion, yes. Those that make an integration with the API should not use latest version since that can have breaking changes at any time. Only a certain API version is stable.
And having all options in all API versions doesn't force external parties to update their integration with the MP Starter API.

Emily-Jiang · 2024-05-01T15:50:22Z

Earlier versions of MP will not return Telemetry. As I already said, MP Version and API version of the Starter app are 2 independent things.

Should the earlier API version such as 2.x return Telemetry at all?

In my opinion, yes. Those that make an integration with the API should not use latest version since that can have breaking changes at any time. Only a certain API version is stable. And having all options in all API versions doesn't force external parties to update their integration with the MP Starter API.

Thanks @rdebusscher ! @majidmostafavi you don't need to create a new version of the API.

Emily-Jiang · 2024-05-01T15:55:34Z

src/main/java/org/eclipse/microprofile/starter/rest/APIEndpointV7.java

+
+import javax.ws.rs.Path;
+
+@Path("/7")


Based on my understanding from @rdebusscher , there is no need to do this change.

breakponchito · 2024-10-08T06:15:56Z

@Emily-Jiang @cesarhernandezgt I found the way to fix the issues from the API MicroProfile Starter but I can't add commits on this PR, it seems someone needs to give me some permission:

remote: Permission to majidmostafavi/microprofile-starter.git denied to breakponchito. fatal: unable to access 'https://github.com/majidmostafavi/microprofile-starter.git/': The requested URL returned error: 403 00:12:20.257: [microprofile-starter] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false push --progress --porcelain majid refs/heads/majidMain:main remote: Permission to majidmostafavi/microprofile-starter.git denied to breakponchito. fatal: unable to access 'https://github.com/majidmostafavi/microprofile-starter.git/': The requested URL returned error: 403
probably I should need to recreate the PR

Emily-Jiang · 2024-10-08T20:50:34Z

@Emily-Jiang @cesarhernandezgt I found the way to fix the issues from the API MicroProfile Starter but I can't add commits on this PR, it seems someone needs to give me some permission:

remote: Permission to majidmostafavi/microprofile-starter.git denied to breakponchito. fatal: unable to access 'https://github.com/majidmostafavi/microprofile-starter.git/': The requested URL returned error: 403 00:12:20.257: [microprofile-starter] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false push --progress --porcelain majid refs/heads/majidMain:main remote: Permission to majidmostafavi/microprofile-starter.git denied to breakponchito. fatal: unable to access 'https://github.com/majidmostafavi/microprofile-starter.git/': The requested URL returned error: 403 probably I should need to recreate the PR

@breakponchito it was the branch from @majidmostafavi . I think you can checkout his branch and then do a new PR.

git checkout -b majidmostafavi-main main
git pull https://github.com/majidmostafavi/microprofile-starter.git main

breakponchito · 2024-10-10T14:11:36Z

@Emily-Jiang @cesarhernandezgt I found the way to fix the issues from the API MicroProfile Starter but I can't add commits on this PR, it seems someone needs to give me some permission:
remote: Permission to majidmostafavi/microprofile-starter.git denied to breakponchito. fatal: unable to access 'https://github.com/majidmostafavi/microprofile-starter.git/': The requested URL returned error: 403 00:12:20.257: [microprofile-starter] git -c credential.helper= -c core.quotepath=false -c log.showSignature=false push --progress --porcelain majid refs/heads/majidMain:main remote: Permission to majidmostafavi/microprofile-starter.git denied to breakponchito. fatal: unable to access 'https://github.com/majidmostafavi/microprofile-starter.git/': The requested URL returned error: 403 probably I should need to recreate the PR

@breakponchito it was the branch from @majidmostafavi . I think you can checkout his branch and then do a new PR.
git checkout -b majidmostafavi-main main
git pull https://github.com/majidmostafavi/microprofile-starter.git main

yes I already create a new PR here: #499
it seems that I need an approval from a maintainer

@Emily-Jiang Could you help me with this?

majidmostafavi added 8 commits January 15, 2024 20:59

Add MicroProfile Version 6

19b4806

Add MicroProfile Version 6

731399c

Add MicroProfile Version 6

3e31654

Add MicroProfile Version 6

0f7893b

Add MicroProfile Version 6

8e4e2d7

Add V7 Test

ecd7897

Remove Open Tracing Add Telemetry

Add V7 Test

246dba6

Remove Open Tracing Add Telemetry

correct Address

d26404d

correct Address

c7ad79f

Resolve Conflict

ae62d40

majidmostafavi requested a review from Emily-Jiang April 10, 2024 10:14

Emily-Jiang reviewed Apr 11, 2024

View reviewed changes

src/main/java/org/eclipse/microprofile/starter/rest/APIEndpointV7.java Show resolved Hide resolved

Update src/main/java/org/eclipse/microprofile/starter/rest/APIEndpoin…

6f5c2dd

…tV7.java

Emily-Jiang reviewed Apr 15, 2024

View reviewed changes

src/main/java/org/eclipse/microprofile/starter/rest/APIEndpointV7.java Outdated Show resolved Hide resolved

Emily-Jiang and others added 5 commits April 15, 2024 17:45

Update src/main/java/org/eclipse/microprofile/starter/rest/APIEndpoin…

6f0e7c0

…tV7.java

MP50 and MP60 use Liveness

532931e

before MP50 and MP60 use Health

Merge remote-tracking branch 'origin/main'

6bbe116

MP60 for Payara Micro

5807fb2

remove MP60 for Payara Micro

b96f0e8

Emily-Jiang reviewed Apr 15, 2024

View reviewed changes

majidmostafavi added 2 commits April 22, 2024 20:33

MP50 and MP60 use Liveness

e17c5ac

before MP50 and MP60 use Health

MP50 and MP60 use Liveness

570f761

before MP50 and MP60 use Health

Emily-Jiang reviewed May 1, 2024

View reviewed changes

majidmostafavi added 5 commits July 15, 2024 20:01

Comment Version V APITest

fdc8e04

unComment Version 7v APITest

2ea634d

Add LIBERTY

b39931a

Add LIBERTY

0e82cda

Add LIBERTY

a633bbc

cesarhernandezgt mentioned this pull request Sep 27, 2024

Update Microprofile adding 6.0 , 6.1 #488

Open

Emily-Jiang merged commit a633bbc into microprofile:main Oct 17, 2024
8 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update for MP6 #494

Update for MP6 #494

majidmostafavi commented Jan 15, 2024

majidmostafavi commented Feb 19, 2024

Emily-Jiang commented Feb 19, 2024

Emily-Jiang commented Mar 25, 2024

luiseufrasio commented Apr 3, 2024

Emily-Jiang commented Apr 3, 2024

Emily-Jiang Apr 15, 2024

Emily-Jiang Apr 15, 2024

rdebusscher Apr 17, 2024

luiseufrasio Apr 17, 2024

luiseufrasio Apr 17, 2024 •

edited

Loading

Emily-Jiang Apr 18, 2024

rdebusscher Apr 20, 2024

Emily-Jiang Apr 20, 2024

rdebusscher Apr 21, 2024

rdebusscher commented Apr 20, 2024

Emily-Jiang commented Apr 20, 2024

rdebusscher commented Apr 21, 2024

Emily-Jiang commented Apr 29, 2024

rdebusscher commented Apr 29, 2024

Emily-Jiang commented Apr 29, 2024

rdebusscher commented May 1, 2024

Emily-Jiang commented May 1, 2024

Emily-Jiang May 1, 2024

breakponchito commented Oct 8, 2024 •

edited

Loading

Emily-Jiang commented Oct 8, 2024 •

edited

Loading

breakponchito commented Oct 10, 2024


		import javax.ws.rs.Path;

		@Path("/7")

Update for MP6 #494

Update for MP6 #494

Conversation

majidmostafavi commented Jan 15, 2024

majidmostafavi commented Feb 19, 2024

Emily-Jiang commented Feb 19, 2024

Emily-Jiang commented Mar 25, 2024

luiseufrasio commented Apr 3, 2024

Emily-Jiang commented Apr 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luiseufrasio Apr 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rdebusscher commented Apr 20, 2024

Emily-Jiang commented Apr 20, 2024

rdebusscher commented Apr 21, 2024

Emily-Jiang commented Apr 29, 2024

rdebusscher commented Apr 29, 2024

Emily-Jiang commented Apr 29, 2024

rdebusscher commented May 1, 2024

Emily-Jiang commented May 1, 2024

Choose a reason for hiding this comment

breakponchito commented Oct 8, 2024 • edited Loading

Emily-Jiang commented Oct 8, 2024 • edited Loading

breakponchito commented Oct 10, 2024

luiseufrasio Apr 17, 2024 •

edited

Loading

breakponchito commented Oct 8, 2024 •

edited

Loading

Emily-Jiang commented Oct 8, 2024 •

edited

Loading