-
Notifications
You must be signed in to change notification settings - Fork 180
Consider buildmode during publish to environment #2115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements support for build modes in the "Publish to Environment" workflow, addressing issue #2107 where the buildMode property specified in DeployTo<Environment> settings was not being respected during deployment.
Changes:
- Added
buildModeparameter to the GetArtifactsForDeployment action to filter artifacts based on the specified build mode - Modified DetermineDeploymentEnvironments to extract buildMode from environment settings and include it in the deployment matrix
- Updated tests to verify buildMode is included in the matrix output with appropriate default values
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| RELEASENOTES.md | Added entry for issue #2107 tracking the buildMode support for environment deployments |
| Actions/GetArtifactsForDeployment/action.yaml | Added buildMode input parameter with default value 'Default' |
| Actions/GetArtifactsForDeployment/README.md | Documented the new buildMode parameter in the action's README |
| Actions/GetArtifactsForDeployment/GetArtifactsForDeployment.ps1 | Implemented logic to handle buildMode when searching for artifacts, correctly prefixing artifact type masks for non-default build modes while maintaining special handling for releases and PowerPlatformSolution artifacts |
| Actions/DetermineDeploymentEnvironments/DetermineDeploymentEnvironments.ps1 | Enhanced to extract buildMode from environment settings and add it to the deployment matrix for each environment |
| Tests/DetermineDeploymentEnvironments.Test.ps1 | Updated test expectations to include buildMode="Default" in matrix output assertions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Actions/GetArtifactsForDeployment/GetArtifactsForDeployment.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Maria Zhelezova <43066499+mazhelez@users.noreply.github.com>
…rup/deploymentenvironment
❔What, Why & How
Currently, the build mode is not considered in the "Publish to Environment" workflow. That means, even if your DeployTo setting contains a buildmode property, that property won't be respected from this workflow.
This PR addresses that by adding a buildmode parameter to the GetArtifactsForDeployment action. For now, we don't handle buildmodes when publishing artifacts from a GitHub release as that scenario would likely need a few more pieces in order to fully work (See #2088).
Related to issue: #2107
✅ Checklist