Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

fix hardcoded port number in Helloworld sample #111

Open
wants to merge 576 commits into
base: master
Choose a base branch
from
Open

fix hardcoded port number in Helloworld sample #111

wants to merge 576 commits into from

Conversation

zllai
Copy link

@zllai zllai commented Nov 19, 2019

I encountered permission denied when running Helloworld sample on Linux, because the client uses ports lower than 1024, which requires root in Linux. However, after I modified the port numbers in run_helloworld_both.sh, the problem still exists.

It turns out the port numbers are hard-coded in Client*/Program.cs. So I made this pull request for following changes:

  1. Modify the default port numbers as following so that no root is required to run the sample on Linux:

    • Client ImmortalCoordinator receive port: 2000
    • Client ImmortalCoordinator send port: 2001
    • Client ImmortalCoordinator CRA port: 2500
    • Server ImmortalCoordinator receive port: 3000
    • Server ImmortalCoordinator send port: 3001
    • Server ImmortalCoordinator CRA port: 3500

  2. Allow clients to receive port numbers in args.

  3. In run_helloworld_client.sh, pass port numbers to client.dll.

  4. Make documents consistent with above changes.

jongoldDB and others added 30 commits January 18, 2019 10:24
@jongoldDB
Rolling back an unnecessary change where a deadlock may have been int…
8c7900c 
…roduced.
@jongoldDB
Only corruption bug fix. No proactive extra locking
1faeb45
@jongoldDB
Putting back testing error checking code which was mistakenly labeled…
656dc1a 
… as unimportant.
@darrenge
Merge branch 'master' of https://github.com/Microsoft/AMBROSIA
c970c13
@jongoldDB
Rare concurrecy bug fixes
9290b5a
@jongoldDB
Merge pull request microsoft#33 from Microsoft/ConcurrencyFixes
f35bbf8 
Rare concurrecy bug fixes
@darrenge
Missing a couple cmp files for Async test
39bd7f0
@jongoldDB
Update HelloWorldExplained.md
238994a
@jongoldDB
Update HelloWorldExplained.md
b978a3a
@jongoldDB
Update HelloWorldExplained.md
73d76c4
@jongoldDB
Update HelloWorldExplained.md
6e1a041
@jongoldDB
Update HelloWorldExplained.md
969333d
@jongoldDB
Update HelloWorldExplained.md
ee05ddc
@nlebeck
Make localListenerThread a background thread (microsoft#31)
d55eec9
@nlebeck
Add UWPExample quickstart and update to match new terminology (micros…
43f0764 
…oft#32)

* Change variable names to match Ambrosia terminology change

* Add quick start instructions to UWPExample README

* Update UWPExample codegen script and improve error messages
@TalZaccai
Refactoring CodeGen tool
3877ffd
@TalZaccai
Merge pull request microsoft#34 from Microsoft/talzacc/codegen_refac
55f79ee 
Refactoring CodeGen tool
@darrenge
slight modification to Async test ... bug preventing it from running …
5f7d823 
…fully
@darrenge
Merge branch 'master' of https://github.com/Microsoft/AMBROSIA
d915fe4
@darrenge
Forgot to remove a commented out line
367acbf
@darrenge
Minor change to one MTF test
b9cfce1
@jongoldDB
Update HOWTO-WINDOWS.md
a87fa14
@jongoldDB
Update HOWTO-WINDOWS.md
1307642
@TalZaccai
codegen bugfix
bc0e987
@TalZaccai
Merge pull request microsoft#35 from Microsoft/talzacc/codegen_bugfix
e96d87d 
codegen bugfix
@jongoldDB
Adding guide for time travel debugging
694f576
@jongoldDB
Merge branch 'master' of https://github.com/Microsoft/AMBROSIA
2a246a7
@jongoldDB
Update TimeTravel-Windows.md
9422134
@jongoldDB
Update TimeTravel-Windows.md
f9190bd
@jongoldDB
Update README.md
dd0babe
darrenge and others added 27 commits August 8, 2019 10:38
@darrenge
Updated nuspec files from licenseUrl to license
e10f28e
@darrenge
Changed Nuget reference from AmbrosiaLibCS to Microsoft.Ambrosia.LibC…
9ae9a8e 
…S ... same for the Debug version too
@darrenge
Updated projects to new Nuget packages
aa1d1a3
@darrenge
Updated all the CRA Nugets to the new properly named CRA - Microsoft.…
4cbb6dd 
…CRA Version=2019.8.8.2
@jongoldDB
Best of breed performance on .NET core Windows is now enabled.
265fb1d
@jongoldDB
Merge branch 'Updating_CRA' of https://github.com/microsoft/AMBROSIA …
0e2e3a1 
…into Updating_CRA
@darrenge
Big change - updated .netcore2.0 to .netcore2.2. For VS 2017 use 2.2.…
2cccbd0 
…108.
@darrenge
Updated to new CRA. Also required change from AddEndpoint to AddEndPo…
4140068 
…intAsync
@darrenge
Updated to use new CRA Nuget package
f872db1
@jongoldDB
Bug Fix: Setting log writer statics for repros
8c5cbea
@darrenge
Added *X* to the Becoming a primary now string.
755b929
@darrenge
minor modifications ... some to stabilize test run but mostly just co…
6f3f37a 
…mments
@darrenge
Updated Microsoft.CRA from 2019.10.2.1 to 2019.10.21.1
7b57ed1
@darrenge
Minor change to CI .sh scripts
1c29c65
@darrenge
Updated nuspec files for the new nuget version 1.0.13
ab3ff38
@darrenge
Updated Ambrosia Nugets from 1.0.12 to 1.0.13
3cfe7f7
@darrenge
Clean up was missing clean up info of one of tests. Fixed now.
236ed47
@darrenge
Trying to update .netcore for docker from 2.0 to 2.2
8e4f895
@darrenge
Wrong version in docker file - trying this one
c8c12e9
@darrenge
Fixed Hello World to run using .netcore 2.2.
7aab5c4
@darrenge
Mostly just added messages to help debug the CI when it fails
1144b61
@darrenge
Modified so does Clean All instead of cleaning each pod
7fa71bb
@darrenge
Minor bug in AKS script
addea67
@darrenge
Updating scripts to get MacOS CI and AKS CI working
3584678
@darrenge
Moved the PTI part of the CI to the end
af3282e
@darrenge
Set it back with PTI at the top ... Runs fine in linux docker mode an…
0c687b0 
…d MacOS (no docker) but Linux (no docker) still fails to build the right files
@zllai
fix hardcoded port number in clients
b55eb82
@msftclas
Copy link

msftclas commented Nov 19, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@zllai zllai changed the title fix hardcoded port number in clients fix hardcoded port number in Helloworld sample Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.