Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

Refactors code to reduce technical debt #119

Open
wants to merge 987 commits into
base: master
Choose a base branch
from
Open

Refactors code to reduce technical debt #119

wants to merge 987 commits into from

Conversation

marodev
Copy link

@marodev marodev commented May 20, 2021

Hello,

This pull request is very simple and aims to reduce the technical debt. It specifically targets the following rules reported by ReSharper:

  • "Replace if statement with null-propagating code" rule
  • "Convert 'as' expression type check and the following null check into pattern matching" rule
  • "Use string interpolation expression" rule

darrenge and others added 30 commits July 30, 2020 12:32
@darrenge
Changed broken link from error to warning
63b8667
@jongoldDB
Adding support for Azure blob logs to IC
7b18db5
@jongoldDB
Making log storage flag case insensitive
75628d8
@jongoldDB
Adding an override to the IC for the log location
0ccc788
@jongoldDB
Fixing help messages
ecf95cd
@darrenge
Putting dotnetcore bindist back to was on 7/22
1300331
@darrenge
Added AMB_OverrideOptions_Test to test IC over ride options
900ec2b
@jongoldDB
Turning off broken async. Leaving in some unreachable code as it will…
911f667 
… be useful when we light up a new async feature.
@jongoldDB
Merge branch 'SledgeHammer' of https://github.com/Microsoft/AMBROSIA …
4741fa7 
…into SledgeHammer
@darrenge
Update CodeGen in build .sh file to set framework to .netstandard
ad38ecc
@darrenge
Added new test and cmp files for the new feature to override send and…
414adfb 
… receive ports, IP add and Log location
@darrenge
Updated help message to match changes
6d532c3
@darrenge
Updated the Net Core help message
b41b8dc
@darrenge
Commented out the Async tests as feature is being changed. If can reu…
13b5f52 
…se tests when it is redone, then just remove comments.
@darrenge
Updated framework on build script
e66f3ed
@darrenge
Another framework update in the build scripts
da52ea0
@darrenge
Hello World broken with removal of Async but it is changing anyways, …
0645c8b 
…so removing from Linux CI build scripts
@darrenge
Added AMB_ClientSideUpgrade_Test and associated cmp files
6c1c3e1
@jongoldDB
Adding command line params for running Job and Server with various in…
aed6286 
…tegrated ICs
@jongoldDB
Merge branch 'SledgeHammer' of https://github.com/Microsoft/AMBROSIA …
02aae9e 
…into SledgeHammer
@darrenge
Added a couple tests for storing logs to blobs
a94d095
@darrenge
Starting Blob cleanup
d7a684e
@jongoldDB
Removing x64 from generated projects. This shouldn't be disruptive.
d78387d
@jongoldDB
Merge branch 'SledgeHammer' of https://github.com/Microsoft/AMBROSIA …
37cd761 
…into SledgeHammer
@darrenge
slight modification to AMB_SaveLogsToFileAndBlob_Test
5977e9d
@darrenge
Updated clean up scripts to use cmdlets that are no longer deprecated…
9424b16 
…. Also added blob clean up for the new feature.
@darrenge
Updated some table clean up. Do not know of way to delete a wild card…
b00f0e8 
… \ like for rows so had to put in a hack to clean up all the rows needed. Also fixed bug in blob clean up.
@darrenge
Updated clean up script to use wild cards to make more efficient.
eb449e2
@darrenge
Take out Helloworld part since it is changing
3681663
@darrenge
Removed some debug code
b30025a
Rich-MSR and others added 29 commits April 5, 2021 12:39
@Rich-MSR
More upgrade clarifications.
e76942d
@darrenge
Updated some tests and corresponding cmp files to match the PTI chang…
cf2b78f 
…es .
@darrenge
Put default configuration to Net461
7456713
@darrenge
Fixed minor timing issue in AMB_InProc_TCP_MigrateClient_Test
ac7287e
@darrenge
Messages were changed in JS Code Gen which caused some tests and cmp …
2b7adec 
…files to be updated
@darrenge
Found some bugs in JS CodeGen which required changes to cmp files and…
f98fa6d 
… also some new negative tests
@darrenge
Added Negative Tests for JS Code Gen
4604b74
@darrenge
Updated with more JS Code Gen tests
e81df28
@jongoldDB
Server no longer exits, but prints "DONE" at the end. Fixes corner ca…
6a9084f 
…se where Job didn't terminate when slow to respond because Server committed suicide before the message got sent.
@jongoldDB
Merge branch 'PostSledgehammer' of https://github.com/Microsoft/AMBROSIA
ab9bb8f 
 into PostSledgehammer
@darrenge
Merged Master changes into PostSledgeHammer. Mostly just test files f…
abe78ce 
…or JS
@darrenge
Updated Test_CodeGen_TSFile to fix a merge conflict.
393487d
@darrenge
Initial stub work for JS_CG_Neg_AmbrosiaSrcFiles_Test
a845585
@darrenge
Minor test tweak
ce6b48c
@darrenge
Added test (JS_CG_Neg_AmbrosiaSrcFiles_Test) that uses the Ambrosia J…
cdeff77 
…S src files as test files for JS code Gen
@Rich-MSR
Modified the 'App Update' section to explain downgrade.
7900f56
@jongoldDB
Adding support for time travel debugging to HelloWorld's Server app
7784271
@jongoldDB
Merge branch 'PostSledgehammer' of https://github.com/Microsoft/AMBROSIA
2f96ce3 
 into PostSledgehammer
@darrenge
Merge from master
fc67145
@darrenge
Fixed a lost minor change to JS Testing during the merge to master du…
3248e85 
…e to conflicts
@darrenge
Updated expected JS Unit Tests from 82 to 83.
0142786
@jongoldDB
Update ActiveActive-Windows.md
a71bf32
@jongoldDB
Update HOWTO-WINDOWS-TwoProc.md
cb23a49
@jongoldDB
Update HelloWorldExplained.md
7bef8d3
@marodev
Fix ReSharper's "UseNullPropagationUrl"
8e6115f
@marodev
Revert "Fix ReSharper's "UseNullPropagationUrl""
f307647 
This reverts commit 8e6115f.
@marodev
Fix ReSharper's "UseNullPropagation"
11270f3
@marodev
Fix ReSharper's "UsePatternMatching"
6ecb574
@marodev
Fix ReSharper's "UseStringInterpolation"
43ec536
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marodev @darrenge @jongoldDB @Rich-MSR @jmfaleiro @mpeina