-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial implementation of DispatcherAgent with configuration and telemetry support #59
base: main
Are you sure you want to change the base?
Conversation
|
||
app.Run(); | ||
|
||
static void BotSetup(IHostApplicationBuilder builder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this instead of ServiceCollectionExtensions.AddBot
and adding additional DI separately?
I'm seeing some warnings
|
"Microsoft.AspNetCore": "Warning" | ||
} | ||
} | ||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments are not permitted in JSON, and shows errors in VSCode
|
||
namespace DispatcherAgent.Utils | ||
{ | ||
public static class Utilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split the methods in this class to other classes with better names? Seems to me the methods to get the conversation links should be in a different class that then ones related to oauth flows
builder.Services.AddHttpClient(); | ||
|
||
// Add AspNet Authentication suitable for token validation for a Bot Service bot (ABS- or SMBA) | ||
builder.Services.AddBotAspNetAuthentication(builder.Configuration); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line throws NRE if config is not set
Introduce the DispatcherAgent with essential models, configuration files, and telemetry capabilities to facilitate bot interactions and performance tracking.