Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dockerfile issue #154

Merged
merged 11 commits into from
Feb 4, 2025
Merged

fix: Dockerfile issue #154

merged 11 commits into from
Feb 4, 2025

Conversation

Harmanpreet-Microsoft
Copy link
Contributor

@Harmanpreet-Microsoft Harmanpreet-Microsoft commented Feb 4, 2025

Purpose

This pull request includes changes to improve the handling of static files in the web application by modifying the Dockerfile and the Flask application routes. The most important changes include copying static files from the frontend build to a new directory and updating the routes to serve these files from the new location.

Changes to static file handling:

  • App/WebApp.Dockerfile: Added commands to copy index.html and favicon.ico from the frontend build to the /usr/src/app/static/ directory.
  • App/app.py: Updated the serve_index and favicon routes to serve files from the static directory instead of the frontend/build directory.
  • App/app.py: Changed the route for serving static files from /assets/<path:path> to /static/<path:path> and updated the directory path accordingly.
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation - NA

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Harmanpreet-Microsoft Harmanpreet-Microsoft changed the title fix :Docker file issue fix :Dockerfile issue Feb 4, 2025
@Roopan-Microsoft Roopan-Microsoft changed the title fix :Dockerfile issue fix: Dockerfile issue Feb 4, 2025
@Roopan-Microsoft Roopan-Microsoft changed the base branch from main to dev February 4, 2025 08:11
@Roopan-Microsoft Roopan-Microsoft merged commit cb5e7fb into dev Feb 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants