[BUG FIX]:fix get torch.version.cuda error when cuda is None in rocm #6909
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjruwase
reviewed
Dec 24, 2024
op_builder/builder.py
Outdated
| @@ -839,7 +839,9 @@ def cxx_args(self): | |||
|
|
|||
| CPU_ARCH = self.cpu_arch() | |||
| SIMD_WIDTH = self.simd_width() | |||
| CUDA_ENABLE = self.is_cuda_enable() | |||
| CUDA_ENABLE = ( | |||
| "-D__DISABLE_CUDA__" if self.is_rocm_pytorch() else self.is_cuda_enable() | |||
There was a problem hiding this comment.
Thanks for this PR. Can you please help with the following changes to improve the codebase beyond your fix?
- Rename the method
is_cuda_enable()-> toget_cuda_compile_flag(), which is more meaningful. - Handle
self.is_rocm_pytorch()case inget_cuda_compile_flag(), returning-D__DISABLE_CUDA__as appropriate.
Are you able to help these changes? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI, I found some error when using deepspeed with rocm-torch
will raise an AttributeError when torch.version.cuda is None. This occurs because the CUDA version in rocm-torch/version.py is set to always be None, leading to potential runtime errors in environments where ROCm is being used.