Add DPO support for DeepSpeed-Chat #828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stceum
requested review from
tjruwase,
ShadenSmith,
conglongli,
awan-10,
eltonzheng,
minjiaz,
duli2012,
mrwyattii,
arashb and
xiaoxiawu-microsoft
as code owners
nuochenpku
approved these changes
Jan 6, 2024
|
Accidentally closed the PR.. Sorry :( |
|
Hi, Thanks for sharing this. Any updates about this PR? Are we planning to merge this feature in? |
Yes, of course! The code for step2 DPO seems to be running as expected. I have done my best to make the code easy to understand and maintain the same style as the other steps. After reviewing the PR again just now, it appears to be missing a README. I will complete it ASAP. I really appreciate your reminder :) |
tjruwase
approved these changes
Dec 18, 2024
|
@stceum, thanks for this great contribution. Apologies for the delayed review. I have approved. Please let me know when it is good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering the advantages of DPO(Direct Preference Optimization) as being "stable, performant, and computationally lightweight, eliminating the need for fitting a reward model, sampling from the LM during fine-tuning, or performing significant hyperparameter tuning", we add DPO support for DeepSpeed-Chat.