add checkpoint #945
Open
add checkpoint #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchen2017
reviewed
Dec 19, 2024
| args.iteration = load_checkpoint(model, optimizer, opt_param_scheduler) | ||
| else: | ||
| args.iteration = 0 | ||
|
|
||
| args.iteration = 0 |
There was a problem hiding this comment.
Delete this line. Otherwise, the args.iteration is wrong if the checkpoint is successfully loaded.
There was a problem hiding this comment.
Also, do we need to change args.train_iters? args.iteration may be larger than args.train_iters if there is a checkpoint.
hwchen2017
reviewed
Dec 19, 2024
| @@ -503,6 +509,8 @@ def load_checkpoint(model, optimizer, opt_param_scheduler, load_arg='load', stri | |||
| load_dir = getattr(args, load_arg) | |||
|
|
|||
| model = unwrap_model(model) | |||
| model_module = model.module | |||
| model = [model_module] | |||
|
|
|||
| state_dict, checkpoint_name, release = _load_base_checkpoint(load_dir, rank0=False) | |||
|
|
|||
There was a problem hiding this comment.
There is no exit_on_missing_checkpoint argument now. It will produce the following error if one has argument load but no checkpoint.
[rank1]: if not args.exit_on_missing_checkpoint:
[rank1]: AttributeError: 'Namespace' object has no attribute 'exit_on_missing_checkpoint'
hwchen2017
reviewed
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support checkpoint for domino