Automation: main-next integrate

microsoft · Jul 28, 2023 · ac64c1f · ac64c1f
2 parents b20a44c + e9e63b8
commit ac64c1f
Show file tree

Hide file tree

Showing 16 changed files with 1,302 additions and 955 deletions.
diff --git a/build-tools/packages/bundle-size-tools/src/utilities/getChunkParsedSize.ts b/build-tools/packages/bundle-size-tools/src/utilities/getChunkParsedSize.ts
@@ -24,9 +24,7 @@ export function getChunkParsedSize(stats: StatsCompilation, chunkId: string | nu
 		return false;
 	});
 
-	if (matchingAsset === undefined) {
-		throw new Error(`Could not find asset for chunk with id '${chunkId}' in the webpack stats`);
-	}
-
-	return matchingAsset.size;
+	// If there's no matching asset it could be that it was removed in the new version of the bundle, not necessarily an
+	// error. In that case return 0 as its size.
+	return matchingAsset?.size ?? 0;
 }
diff --git a/experimental/dds/tree2/src/feature-libraries/modular-schema/modularChangeFormat.ts b/experimental/dds/tree2/src/feature-libraries/modular-schema/modularChangeFormat.ts
@@ -26,7 +26,7 @@ export const EncodedChangeAtomId = Type.Object(
 		/**
 		 * Uniquely identifies the changeset within which the change was made.
 		 */
-		revision: Type.Union([RevisionTagSchema, Type.Undefined()]),
+		revision: Type.Optional(RevisionTagSchema),
 		/**
 		 * Uniquely identifies, in the scope of the changeset, the change made to the field.
 		 */

diff --git a/experimental/dds/tree2/src/feature-libraries/modular-schema/modularChangeTypes.ts b/experimental/dds/tree2/src/feature-libraries/modular-schema/modularChangeTypes.ts
@@ -23,7 +23,7 @@ export interface ChangeAtomId {
 	 * Uniquely identifies the changeset within which the change was made.
 	 * Only undefined when referring to an anonymous changesets.
 	 */
-	readonly revision: RevisionTag | undefined;
+	readonly revision?: RevisionTag;
 	/**
 	 * Uniquely identifies, in the scope of the changeset, the change made to the field.
 	 */