Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup tests in presence tracker #16040

Closed
wants to merge 14 commits into from
Closed

Setup tests in presence tracker #16040

wants to merge 14 commits into from

Conversation

sonalideshpandemsft
Copy link
Contributor

@sonalideshpandemsft sonalideshpandemsft commented Jun 16, 2023 •
edited
Loading

@sonalideshpandemsft sonalideshpandemsft marked this pull request as draft June 16, 2023 20:38
@github-actions github-actions bot added area: contributor experience area: dev experience Improving the experience of devs building on top of fluid area: examples Changes that focus on our examples dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Jun 16, 2023
@github-actions github-actions bot removed the area: dev experience Improving the experience of devs building on top of fluid label Jun 16, 2023
@sonalideshpandemsft sonalideshpandemsft force-pushed the azure-client-signaler branch 2 times, most recently from 00488be to 2d3695b Compare June 16, 2023 22:49
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jun 16, 2023
@github-actions github-actions bot added area: contributor experience area: dev experience Improving the experience of devs building on top of fluid dependencies Pull requests that update a dependency file and removed area: contributor experience labels Jun 27, 2023
@sonalideshpandemsft sonalideshpandemsft marked this pull request as ready for review June 29, 2023 16:06
@sonalideshpandemsft sonalideshpandemsft marked this pull request as draft June 29, 2023 16:06
@sonalideshpandemsft sonalideshpandemsft force-pushed the azure-client-signaler branch 3 times, most recently from 5af0e57 to fd92879 Compare July 5, 2023 02:15
@sonalideshpandemsft sonalideshpandemsft marked this pull request as ready for review July 5, 2023 16:34
@sonalideshpandemsft sonalideshpandemsft force-pushed the azure-client-signaler branch 2 times, most recently from 149003e to cb4b43f Compare July 5, 2023 16:39
@github-actions github-actions bot removed the area: dev experience Improving the experience of devs building on top of fluid label Jul 5, 2023
@sonalideshpandemsft sonalideshpandemsft marked this pull request as draft July 5, 2023 18:06
ChumpChief
ChumpChief reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@ChumpChief ChumpChief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised to see the change to make these DataObjects -- I think the tests look fine, but not sure we want to require persisting data for these scenarios?

examples/apps/presence-tracker/src/FocusTracker.ts
name: string;
}

export class FocusTracker extends DataObject implements IFocusTracker {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choosing to make FocusTracker a DataObject means it becomes part of the persisted state of the container - I'm not sure if this is something we want? At minimum it is a pretty significant change in the purpose of the demo.

@sonalideshpandemsft
Copy link
Contributor Author

closing in favor of #16274

@sonalideshpandemsft sonalideshpandemsft deleted the azure-client-signaler branch July 6, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChumpChief ChumpChief ChumpChief left review comments

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

Assignees
No one assigned
Labels
area: examples Changes that focus on our examples base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonalideshpandemsft @ChumpChief