Enhance reliability of obtaining colletion from interval

packages/dds/sequence/src/intervalCollection.ts

@@ -1367,6 +1367,17 @@ export class LocalIntervalCollection<TInterval extends ISerializableInterval> {
 			}
 
 			if (props) {
+				// This check is intended to prevent scenarios where a random interval is created and then
+				// inserted into a collection. The aim is to ensure that the collection is created first
+				// then the user can create/add intervals based on the collection
+				if (
+					props[reservedRangeLabelsKey] !== undefined &&
+					props[reservedRangeLabelsKey][0] !== this.label
+				) {
+					throw new LoggingError(
+						"Adding an interval that belongs to another interval collection is not permitted",
+					);
+				}
 				interval.addProperties(props);
 			}
 			interval.properties[reservedIntervalIdKey] ??= uuid();
@@ -2228,6 +2239,13 @@ export class IntervalCollection<TInterval extends ISerializableInterval>
 		if (!props) {
 			throw new LoggingError("changeProperties should be called with a property set");
 		}
+		// prevent the overwriting of an interval label, it should remain unchanged
+		// once it has been inserted into the collection.
+		if (props[reservedRangeLabelsKey] !== undefined) {
+			throw new LoggingError(
+				"The label property should not be modified once inserted to the collection",
+			);
+		}
 
 		const interval = this.getIntervalById(id);
 		if (interval) {

packages/dds/sequence/src/revertibles.ts

@@ -359,7 +359,6 @@ export function discardSharedStringRevertibles(
 	});
 }
 
-// Uses of referenceRangeLabels will be removed once AB#4081 is completed.
 function revertLocalAdd(
 	string: SharedString,
 	revertible: TypedRevertible<typeof IntervalOpType.ADD>,

packages/dds/sequence/src/test/intervalCollection.spec.ts

@@ -5,7 +5,11 @@
 
 import { strict as assert } from "assert";
 import { IChannelServices } from "@fluidframework/datastore-definitions";
-import { ReferenceType, SlidingPreference } from "@fluidframework/merge-tree";
+import {
+	ReferenceType,
+	SlidingPreference,
+	reservedRangeLabelsKey,
+} from "@fluidframework/merge-tree";
 import {
 	MockFluidDataStoreRuntime,
 	MockContainerRuntimeFactory,
@@ -14,6 +18,7 @@ import {
 	MockStorage,
 	MockEmptyDeltaConnection,
 } from "@fluidframework/test-runtime-utils";
+import { LoggingError } from "@fluidframework/telemetry-utils";
 import { SharedString } from "../sharedString";
 import { SharedStringFactory } from "../sequenceFactory";
 import {
@@ -1732,4 +1737,37 @@ describe("SharedString interval collections", () => {
 			});
 		});
 	});
+
+	describe("maintain consistency between the collection label and that in interval properties", () => {
+		let collection;
+
+		beforeEach(() => {
+			sharedString.initializeLocal();
+			collection = sharedString.getIntervalCollection("test");
+			sharedString.insertText(0, "xyz");
+		});
+
+		it("can not insert the interval which does not belong to this collection", () => {
+			assert.throws(
+				() => {
+					collection.add(1, 1, IntervalType.SlideOnRemove, {
+						[reservedRangeLabelsKey]: ["test2"],
+					});
+				},
+				LoggingError,
+				"The collection is unable to add an interval which does not belong to it",
+			);
+		});
+
+		it("can not modify the interval's label after it has been inserted to the collection", () => {
+			const id = collection.add(1, 1, IntervalType.SlideOnRemove).getIntervalId();
+			assert.throws(
+				() => {
+					collection.changeProperties(id, { [reservedRangeLabelsKey]: ["test2"] });
+				},
+				LoggingError,
+				"The label property of an interval should not be modified once inserted to the collection",
+			);
+		});
+	});
 });