Updating logging on Scribe to include lastSummaryHead #16252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: server
manishgargd
approved these changes
Jul 5, 2023
pradeepvairamani
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have recently seen an increased number of Client Summary failures in Scribe due to the proposed parent summary not matching actual parent summary.
Based on the current logging, we have narrowed the failure down to this condition:
lastSummaryHead !== content.headFluidFramework/server/routerlicious/packages/lambdas/src/scribe/summaryWriter.ts
Line 112 in 08a28be
However, we can't proceed with the investigation since
lastSummaryHeadis currently not logged. Therefore, this PR attempts to address that.