-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IContainerContext removals #16262
IContainerContext removals #16262
Conversation
@tylerbutler the changes to UPCOMING.md look more dramatic than I expected - wanted to make sure I'm not doing something wrong here. |
⯆ @fluid-example/bundle-size-tests: -404 Bytes
Baseline commit: da246ca |
Forgot that we can also remove the implementations here too, removed in latest. |
I see the policy check is running a "generate minor" but I think it's appropriate for it to instead generate major since this is targeting next branch? |
Working as expected right now, but it looks like next may have some unexpected changesets. I'll look more at it later, but once the latest main is merged (#16275), let's see what things look like. |
@ChumpChief Try merging the latest next into this PR; I think that should improve the UPCOMING.md situation, but I still need to figure out how to deal with main vs. next more generally. |
Merged latest, but I think UPCOMING.md looks wrong in current "generate:upcoming": "flub generate upcoming --releaseGroup client -t |
Please review this PR: @sonalideshpandemsft @tylerbutler @scottn12 |
Tagging merge-next since I think the UPCOMING behavior is consistent with what's in |
Yes, what you're describing is the expected behavior. UPCOMING.md always contains ONLY minor changes. That's what I meant by "figure out how to deal with main vs. next more generally." |
Followups from #16180 and #16182. AB#4879