Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps (newest) on server release group in the client release group #16311

Merged
merged 6 commits into from
Jul 12, 2023
Merged

Update deps (newest) on server release group in the client release group #16311

merged 6 commits into from
Jul 12, 2023

Conversation

NicholasCouri
Copy link
Contributor

@NicholasCouri NicholasCouri commented Jul 11, 2023 •
edited
Loading

Updated the following:

client (release group)

Dependencies on server updated:

@fluidframework/server-services-client: ^1.0.0-173913
@fluidframework/server-local-server: ^1.0.0-173913
@fluidframework/gitresources: ^1.0.0-173913
@fluidframework/protocol-base: ^1.0.0-173913
@fluidframework/server-services-core: ^1.0.0-173913
@fluidframework/server-test-utils: ^1.0.0-173913

Description

Updating server dependencies on next

@NicholasCouri
Update deps (newest) on server release group in the client release group
31130bd 
Updated the following:

  client (release group)

Dependencies on server updated:

  @fluidframework/server-services-client: ^1.0.0-173913
  @fluidframework/server-local-server: ^1.0.0-173913
  @fluidframework/gitresources: ^1.0.0-173913
  @fluidframework/protocol-base: ^1.0.0-173913
  @fluidframework/server-services-core: ^1.0.0-173913
  @fluidframework/server-test-utils: ^1.0.0-173913
@NicholasCouri
Consume convertWholeSummaryTreeToSummaryTree
7119f8c
@NicholasCouri NicholasCouri requested review from msfluid-bot and a team as code owners July 11, 2023 16:42
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: driver Driver related issues area: examples Changes that focus on our examples area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: next PRs targeted against next branch labels Jul 11, 2023
@github-actions github-actions bot removed the area: server Server related issues (routerlicious) label Jul 11, 2023
@NicholasCouri NicholasCouri changed the title Update deps (newest) on server release group in the client release group and consume convertFirstSummaryWholeSummaryTreeToSummaryTree Update deps (newest) on server release group in the client release group Jul 11, 2023
tylerbutler
tylerbutler approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good once CI passes.

@NicholasCouri NicholasCouri requested review from a team as code owners July 11, 2023 18:17
@msfluid-bot
Copy link
Collaborator

⯆ @fluid-example/bundle-size-tests: -26 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 432.5 KB 432.51 KB ⯅ +6 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 231.83 KB 231.84 KB ⯅ +6 Bytes
loader.js 144.4 KB 144.36 KB ⯆ -38 Bytes
map.js 44.88 KB 44.88 KB ■ No change
matrix.js 138.07 KB 138.07 KB ■ No change
odspDriver.js 87.87 KB 87.87 KB ■ No change
odspPrefetchSnapshot.js 41.12 KB 41.12 KB ■ No change
sharedString.js 154.17 KB 154.17 KB ■ No change
sharedTree2.js 236.83 KB 236.83 KB ■ No change
Total Size 1.63 MB 1.63 MB ⯆ -26 Bytes

Baseline commit: 3289345

Generated by 🚫 dangerJS against 4ee8d3c

@NicholasCouri NicholasCouri self-assigned this Jul 12, 2023
@github-actions
Copy link
Contributor

Please review this PR: @sonalideshpandemsft @tylerbutler @scottn12

@tylerbutler tylerbutler merged commit 6c64c07 into microsoft:next Jul 12, 2023
30 checks passed
anthony-murphy added a commit that referenced this pull request Jul 12, 2023
@anthony-murphy
Revert "Update deps (newest) on server release group in the client re…
3005b7a 
…lease group (#16311)"

This reverts commit 6c64c07.
@anthony-murphy anthony-murphy mentioned this pull request Jul 12, 2023
Merged
anthony-murphy added a commit that referenced this pull request Jul 12, 2023
@anthony-murphy
Revert "Update deps (newest) on server release group in the client re…
b2e79b4 
…lease group" (#16337)

Reverts #16311

This change is causing execution time breaks in our real service tests
due to a breaking change in a semver compatible release of server. we
need to fix the release, or update the next branch. for now we will
revert the bump while the real fix is determined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbutler tylerbutler tylerbutler approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot msfluid-bot is a code owner

Assignees
No one assigned
Labels
area: dds: propertydds area: dds: sharedstring area: dds Issues related to distributed data structures area: driver Driver related issues area: examples Changes that focus on our examples area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: next PRs targeted against next branch dependencies Pull requests that update a dependency file msftbot: merge-next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicholasCouri @msfluid-bot @tylerbutler