Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps (minor) on server release group in the client release group #16358

Merged
merged 3 commits into from
Jul 15, 2023
Merged

Update deps (minor) on server release group in the client release group #16358

merged 3 commits into from
Jul 15, 2023

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Jul 13, 2023 •
edited
Loading

Updated the following:

client (release group)

Dependencies on server updated:

@fluidframework/gitresources: 1.0.0-1.0.0-175213
@fluidframework/server-kafka-orderer: 1.0.0-175213
@fluidframework/server-lambdas: 1.0.0-175213
@fluidframework/server-lambdas-driver: 1.0.0-175213
@fluidframework/server-local-server: 1.0.0-175213
@fluidframework/server-memory-orderer: 1.0.0-175213
@fluidframework/protocol-base: 1.0.0-175213
@fluidframework/server-routerlicious: 1.0.0-175213
@fluidframework/server-routerlicious-base: 1.0.0-175213
@fluidframework/server-services: 1.0.0-175213
@fluidframework/server-services-client: 1.0.0-175213
@fluidframework/server-services-core: 1.0.0-175213
@fluidframework/server-services-ordering-kafkanode: 1.0.0-175213
@fluidframework/server-services-ordering-rdkafka: 1.0.0-175213
@fluidframework/server-services-ordering-zookeeper: 1.0.0-175213
@fluidframework/server-services-shared: 1.0.0-175213
@fluidframework/server-services-telemetry: 1.0.0-175213
@fluidframework/server-services-utils: 1.0.0-175213
@fluidframework/server-test-utils: 1.0.0-175213

@tylerbutler
Update deps (minor) on server release group in the client release group
6dcbb6c 
Updated the following:

  client (release group)

Dependencies on server updated:

  @fluidframework/gitresources: 1.0.0-173913
  @fluidframework/server-kafka-orderer: 1.0.0-173913
  @fluidframework/server-lambdas: 1.0.0-173913
  @fluidframework/server-lambdas-driver: 1.0.0-173913
  @fluidframework/server-local-server: 1.0.0-173913
  @fluidframework/server-memory-orderer: 1.0.0-173913
  @fluidframework/protocol-base: 1.0.0-173913
  @fluidframework/server-routerlicious: 1.0.0-173913
  @fluidframework/server-routerlicious-base: 1.0.0-173913
  @fluidframework/server-services: 1.0.0-173913
  @fluidframework/server-services-client: 1.0.0-173913
  @fluidframework/server-services-core: 1.0.0-173913
  @fluidframework/server-services-ordering-kafkanode: 1.0.0-173913
  @fluidframework/server-services-ordering-rdkafka: 1.0.0-173913
  @fluidframework/server-services-ordering-zookeeper: 1.0.0-173913
  @fluidframework/server-services-shared: 1.0.0-173913
  @fluidframework/server-services-telemetry: 1.0.0-173913
  @fluidframework/server-services-utils: 1.0.0-173913
  @fluidframework/server-test-utils: 1.0.0-173913
@tylerbutler tylerbutler requested review from msfluid-bot and a team as code owners July 13, 2023 02:11
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: driver Driver related issues area: examples Changes that focus on our examples area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: next PRs targeted against next branch labels Jul 13, 2023
NicholasCouri
NicholasCouri reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@NicholasCouri NicholasCouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to rename the buildhierarchy calls or we will have build problems, I think

@tylerbutler tylerbutler requested review from a team as code owners July 13, 2023 04:54
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Jul 13, 2023 •
edited
Loading

⯆ @fluid-example/bundle-size-tests: -26 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 432.2 KB 432.21 KB ⯅ +6 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 231.83 KB 231.84 KB ⯅ +6 Bytes
loader.js 144.4 KB 144.36 KB ⯆ -38 Bytes
map.js 44.88 KB 44.88 KB ■ No change
matrix.js 138.07 KB 138.07 KB ■ No change
odspDriver.js 87.87 KB 87.87 KB ■ No change
odspPrefetchSnapshot.js 41.12 KB 41.12 KB ■ No change
sharedString.js 154.17 KB 154.17 KB ■ No change
sharedTree2.js 236.83 KB 236.83 KB ■ No change
Total Size 1.63 MB 1.63 MB ⯆ -26 Bytes

Baseline commit: b2e79b4

Generated by 🚫 dangerJS against 212a580

@tylerbutler
Copy link
Member Author

@NicholasCouri I'm still not sure we should merge this, since it requires us changing client code to use the wrong name. We can merge this, but it's not required. We could instead prerelease another build and integrate that build, with the correct API name. Or go straight to releasing 1.0. Your call. I don't mind doing these extra steps for the experience, I just want to be clear what's necessary vs not. I won't be online much tomorrow, so ping the release engineers if anything can't wait until Friday.

@NicholasCouri
Copy link
Contributor

@NicholasCouri I'm still not sure we should merge this, since it requires us changing client code to use the wrong name. We can merge this, but it's not required. We could instead prerelease another build and integrate that build, with the correct API name. Or go straight to releasing 1.0. Your call. I don't mind doing these extra steps for the experience, I just want to be clear what's necessary vs not. I won't be online much tomorrow, so ping the release engineers if anything can't wait until Friday.

I'm ok either way. I can publish a new prerelease.

@tylerbutler
Copy link
Member Author

@NicholasCouri I'm merging since the tests pass; I think we will need to update tinylicious before we release 6.0, but we can do that in separate commits.

@tylerbutler
Copy link
Member Author

Related PR bumping tinylicious: #16380

@tylerbutler tylerbutler merged commit 5bd3705 into microsoft:next Jul 15, 2023
29 checks passed
@tylerbutler tylerbutler deleted the bump_deps_server_minor_client branch July 15, 2023 00:35
@tylerbutler tylerbutler added the release Pull requests created for releasing a new version of FF. label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasCouri NicholasCouri NicholasCouri approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot msfluid-bot is a code owner

Assignees
No one assigned
Labels
area: dds: propertydds area: dds: sharedstring area: dds Issues related to distributed data structures area: driver Driver related issues area: examples Changes that focus on our examples area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: next PRs targeted against next branch dependencies Pull requests that update a dependency file release Pull requests created for releasing a new version of FF.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylerbutler @msfluid-bot @NicholasCouri