Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup mock APIs #16568

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Cleanup mock APIs #16568

merged 4 commits into from
Jul 31, 2023

Conversation

andre4i
Copy link
Contributor

@andre4i andre4i commented Jul 26, 2023 •
edited by azure-boards bot
Loading

Description

These capabilities have been added as optional in main for compatibility reasons. In next we can make them required.

Leftover from AB#4980

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring area: runtime Runtime related issues public api change Changes to a public API base: next PRs targeted against next branch labels Jul 26, 2023
@andre4i andre4i marked this pull request as ready for review July 26, 2023 20:50
@andre4i andre4i requested review from msfluid-bot and a team as code owners July 26, 2023 20:50
@github-actions
Copy link
Contributor

This PR is ready to merge! Please review it and squash merge into next: @sonalideshpandemsft @tylerbutler @scottn12

@tylerbutler tylerbutler added the changeset-required PR requires a changeset label Jul 26, 2023
@andre4i andre4i requested a review from a team as a code owner July 31, 2023 16:06
@github-actions
Copy link
Contributor

This PR requires a changeset and it has one! Good job!

@tylerbutler
Copy link
Member

I'll merge this after #16611 is merged.

@tylerbutler tylerbutler merged commit e43927f into microsoft:next Jul 31, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kian-thompson kian-thompson kian-thompson approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot msfluid-bot is a code owner

Assignees
No one assigned
Labels
area: dds: sharedstring area: dds Issues related to distributed data structures area: runtime Runtime related issues base: next PRs targeted against next branch changeset-required PR requires a changeset msftbot: merge-next public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andre4i @tylerbutler @kian-thompson