Automation: main-next integrate #16616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Build-tools (the release group) should use the version of build-tools (the package) that it contains, not a published one. Also it does not require test-tools since it just uses mocha and not jest.
This PR introduces the redis implementation of filesystem APIs, to be used by isomorphic-git within GitRest. The implementation was based on Node.js's FileSystem promise APIs (https://nodejs.org/api/fs.html#promises-api ) and also isomorphic-git's use of the filesystem APIs (https://github.com/isomorphic-git/isomorphic-git/blob/main/src/models/FileSystem.js ). ## Reviewer Guidance This PR is heavily based on the AzureBlob FS implementation in azure fluid relay. The common functions that can be used by redisFS and AzureBlobFS have also been moved into OSS in this PR. Currently, we can use Redis FS with isomorphic git using a config. In the future PR, this will be controlled by a flag sent by the driver at the time of document creation.
… was reachable or not) (#16328) ## Description Item: https://dev.azure.com/fluidframework/internal/_workitems/edit/4745 8s of MaxReconnectDelayInMs seems less. Increase it to 30s. This was done due to a problem we faced recently where "retry-after" was not present in the Throttling error due to some error at server side and client was retrying very aggressively as 8s sec wait was too less. So increase it to 30s in case the service or socket is reachable or not. The general philosophy behind this PR is the following: 1. If we can't reach service (including being offline), we do not have any data on when this situation would change, so we want to keep retrying relatively frequently, to reduce delay from service becoming reachable to a point client becomes connected and up to date. So, continue to use back-off strategy with max 8 sec between retries. 2. If we reached service and it returned some retryable error, but there is no retryAfter property communicated to us, then we will back-off exponentially with max delay of 30 seconds between retries. This gives more time for service to recover, and avoids whole application being throttled due to too many calls performed by all clients. 8 & 30 seconds could be changed in the future, but we want to keep two different policies for those two distinct cases. --------- Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local>
fixing a formatting issue from the previous PR
⯅ @fluid-example/bundle-size-tests: +200 Bytes
Baseline commit: e43927f |
tylerbutler
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main-next integrate PR
The aim of this pull request is to sync main and next branch. If this PR is assigned to you, you need to do the following:
git commit --amend -m "Automation: main-next integrate"git push --force-with-lease