Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sequence): resolve 0x54e crash #17102

Closed
wants to merge 15 commits into from
Closed

fix(sequence): resolve 0x54e crash #17102

wants to merge 15 commits into from

Conversation

connorskees
Copy link
Contributor

@connorskees connorskees commented Aug 30, 2023 •
edited by azure-boards bot
Loading

Fixes the 0x54e crash we've been seeing in sequence fuzz tests by using the reference positions of the current interval rather than plain numbers to get the segment+offset.

ADO#5337

AB#5337

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring area: runtime Runtime related issues base: main PRs targeted against main branch labels Aug 30, 2023
@connorskees connorskees marked this pull request as ready for review August 30, 2023 19:07
@connorskees connorskees requested a review from a team as a code owner August 30, 2023 19:07
@github-actions github-actions bot removed the area: runtime Runtime related issues label Aug 30, 2023
@connorskees connorskees requested review from Abe27342 and removed request for Abe27342 August 30, 2023 19:08
@github-actions github-actions bot added the area: build Build related issues label Sep 19, 2023
@connorskees connorskees removed area: tests Tests to add, test infrastructure improvements, etc area: dds: propertydds area: odsp-driver public api change Changes to a public API area: dds: tree base: main PRs targeted against main branch labels Sep 19, 2023
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring base: next PRs targeted against next branch labels Sep 19, 2023
@connorskees connorskees removed the request for review from Abe27342 September 20, 2023 18:42
@github-actions github-actions bot added the public api change Changes to a public API label Sep 21, 2023
@github-actions github-actions bot added the area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct label Oct 1, 2023
@connorskees connorskees mentioned this pull request Oct 5, 2023
Closed
@github-actions github-actions bot added the area: tests Tests to add, test infrastructure improvements, etc label Oct 5, 2023
@connorskees connorskees changed the title feat(sequence): use interval endpoints to reconstruct rebased positions+fix fuzz test minimization fix(sequence): resolve 0x54e crash Oct 5, 2023
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot msfluid-bot is a code owner

Assignees
No one assigned
Labels
area: dds: sharedstring area: dds Issues related to distributed data structures area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: tests Tests to add, test infrastructure improvements, etc base: next PRs targeted against next branch public api change Changes to a public API status: stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@connorskees