Automation: main-next integrate #18748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds [the CLI](https://github.com/arethetypeswrong/arethetypeswrong.github.io/tree/main/packages/cli) from <https://arethetypeswrong.github.io> to our client packages and adds a script that runs it against the package. The check is slow because it packs the package first and runs on the packed contents. Because the check is slow, it does not run automatically during local builds but can be triggered manually. In CI the checks run as a test since they rely on the build output. Ideally this check would be done in the "pack" phase since we are already packing packages there and could run on the packed content directly. But that is a bigger CI-centric change, so I opted not to do that right now. There are several azure projects that are [producing invalid ESM types](https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/docs/problems/FalseCJS.md). Those failures are ignored for now using .attw.json config files in the individual projects - they'll be cleaned up as we fix the types/exports field for those packages. This PR also removes the exports field from most packages, so that we can re-enable exports in a controlled fashion, while being protected from releasing bad types by attw.
github-actions
bot
added
community-contribution
base: next
⯅ @fluid-example/bundle-size-tests: +14 Bytes
Baseline commit: 2c8e405 |
tylerbutler
force-pushed
the
main-next-458f23f
branch
from
be68147
to
e666815
Compare
sonalideshpandemsft
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main-next integrate PR
DO NOT MERGE THIS PR USING THE GITHUB UI.
The aim of this pull request is to sync main and next branch. This branch has MERGE CONFLICTS with next due to this commit. If this PR is assigned to you, you need to do the following:
git fetch --all-- this ensures your remote refs are updatedgit remote -v-- displays the list of remote repositories associated with your Git repository along with their corresponding URLs. You have to choose the remote associated with the microsoft/FluidFramework repository. Change the remote name in these example commands if yours is not upstream.git checkout -b next-merge-head upstream/next-- make a temporary branch at next.git merge upstream/main-next-458f23f-- merge next into main-next-458f23fgit add .-- stage all the local changesgit commit -m "Automation: main-next integrate"-- commit the mergegit checkout main-next-458f23f-- check out the mergeBranch locallygit merge next-merge-head --ff-only-- fast-forward to the merge commitgit push upstream-- and push it to upstream (your upstream remote name may be different)git commit --amend -m "Automation: main-next integrate"git push --force-with-leaseOnce CI passes and the PR is ready to merge, add the "msftbot: merge-next" label to the PR and one of the people with merge permissions will merge it in.