Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation: main-next integrate #18765

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Automation: main-next integrate #18765

merged 2 commits into from
Dec 12, 2023

Conversation

msfluid-bot
Copy link
Collaborator

main-next integrate PR

DO NOT MERGE THIS PR USING THE GITHUB UI.

The aim of this pull request is to sync main and next branch. This branch has MERGE CONFLICTS with next due to this commit. If this PR is assigned to you, you need to do the following:

  1. Acknowledge the pull request by adding a comment -- "Actively working on it".
  2. Merge main-next-7a8b0b1 into the target branch, next. The direction of the merge matters! You need to checkout next and merge main-next-7a8b0b1 into it, then fast-forward main-next-7a8b0b1 to the merge commit. To do that use the following git commands:
  • git fetch --all -- this ensures your remote refs are updated
  • git remote -v -- displays the list of remote repositories associated with your Git repository along with their corresponding URLs. You have to choose the remote associated with the microsoft/FluidFramework repository. Change the remote name in these example commands if yours is not upstream.
  • git checkout -b next-merge-head upstream/next -- make a temporary branch at next.
  • git merge upstream/main-next-7a8b0b1 -- merge next into main-next-7a8b0b1
  1. Resolve any merge conflicts between the branches, then commit all the changes using the following commands:
  • git add . -- stage all the local changes
  • git commit -m "Automation: main-next integrate" -- commit the merge
  1. Fast-forward the main-next-7a8b0b1 branch to the merge commit and push to the remote.
  • git checkout main-next-7a8b0b1 -- check out the mergeBranch locally
  • git merge next-merge-head --ff-only -- fast-forward to the merge commit
  • git push upstream -- and push it to upstream (your upstream remote name may be different)
  1. Address any CI failures. If you need to make additional changes to the PR, always amend the commit using the following git commands:
  • git commit --amend -m "Automation: main-next integrate"
  • git push --force-with-lease

Once CI passes and the PR is ready to merge, add the "msftbot: merge-next" label to the PR and one of the people with merge permissions will merge it in.

…ollups (#18621)

Expands on existing API-Extractor patching in place.

This patch mitigates an issue where imports (potentially from other
packages) are trimmed from the generated type rollups based on the
release tags associated with the imported items.
This issue has the potential to create invalid type rollups.
The mitigation is to simply not trim imports in the type rollups -
introducing (potentially) unused type imports is benign and should have
negligible impact on file sizes in most cases.
The relevant changes can be found on this branch:
https://github.com/Josmithr/rushstack/tree/dont-trim-imports
Related github issue: microsoft/rushstack#4425
@Josmithr
Copy link
Contributor

Actively working on it

@Josmithr Josmithr closed this Dec 12, 2023
@Josmithr Josmithr reopened this Dec 12, 2023
Copy link
Contributor

This PR is ready to merge! Please review it and squash merge into next: @sonalideshpandemsft @tylerbutler @scottn12

@msfluid-bot
Copy link
Collaborator Author

@fluid-example/bundle-size-tests: +14 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 452.78 KB 452.78 KB +2 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 239.23 KB 239.23 KB No change
loader.js 166.81 KB 166.82 KB +2 Bytes
map.js 46.7 KB 46.7 KB +2 Bytes
matrix.js 147.36 KB 147.36 KB +2 Bytes
odspDriver.js 90.35 KB 90.36 KB +2 Bytes
odspPrefetchSnapshot.js 41.82 KB 41.82 KB +2 Bytes
sharedString.js 165.55 KB 165.55 KB No change
sharedTree2.js 287.36 KB 287.36 KB No change
Total Size 1.75 MB 1.75 MB +14 Bytes

Baseline commit: 4582ffc

Generated by 🚫 dangerJS against a528075

@sonalideshpandemsft sonalideshpandemsft merged commit a528075 into next Dec 12, 2023
34 checks passed
@sonalideshpandemsft sonalideshpandemsft deleted the main-next-7a8b0b1 branch December 12, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants