Automation: main-next integrate #18779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used on the alpha surface of client, so also need to be marked alpha: https://github.com/microsoft/FluidFramework/blob/b3e6b6bbd57222548a5d914da1220cb2c1a89be0/packages/loader/container-loader/src/protocol.ts#L9 Co-authored-by: Tony Murphy <anthonm@microsoft.com>
We have mechanisms in place that help prevent ops from being resubmitted if they were successfully sequenced by service (but our client didn't have time to see the ack before disconnecting). Added comments in some key places so people interested can quickly find the code that prevents this. Example scenario: | **Step** | **clientId value** | **PendingStateManager** | |--------------------------------------------|----------------|---------------------| | Client A sends op 1 | Client A | [op 1] | | Client A disconnects | Client A | [op 1] | | Client A reconnects as Client B | Client A | [op 1] | | **Start wait to see "leave" op from Client A** | Client A | [op 1] | | See ack for op 1 | Client A | **[]** | | See "leave" for Client A | **Client B** | [] |
After a data store is deleted as a result of sweep, further modification to it must be prevented to cause any data loss. This has been added via a GC sweep op which will be received by all clients #18632. However, due to an unexpected bug, a client could have a (to be) deleted data store loaded and before it receives the GC sweep op, this data store can send an op or signal. These ops must be ignored after the data store is deleted to not cause document corruption. This PR adds this logic. An error is still logged and it can be used to identify if such case ever happens. AB#6113
⯅ @fluid-example/bundle-size-tests: +1.1 KB
Baseline commit: 5d2dce4 |
sonalideshpandemsft
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main-next integrate PR
DO NOT MERGE THIS PR USING THE GITHUB UI.
The aim of this pull request is to sync main and next branch. If this PR is assigned to you, you need to do the following:
git commit --amend -m "Automation: main-next integrate"git push --force-with-leaseOnce CI passes and the PR is ready to merge, add the "msftbot: merge-next" label to the PR and one of the people with merge permissions will merge it in.