Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation: main-next integrate #18785

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Automation: main-next integrate #18785

merged 2 commits into from
Dec 12, 2023

Conversation

msfluid-bot
Copy link
Collaborator

main-next integrate PR

DO NOT MERGE THIS PR USING THE GITHUB UI.

The aim of this pull request is to sync main and next branch. This branch has MERGE CONFLICTS with next due to this commit. If this PR is assigned to you, you need to do the following:

  1. Acknowledge the pull request by adding a comment -- "Actively working on it".
  2. Merge main-next-12c83d2 into the target branch, next. The direction of the merge matters! You need to checkout next and merge main-next-12c83d2 into it, then fast-forward main-next-12c83d2 to the merge commit. To do that use the following git commands:
  • git fetch --all -- this ensures your remote refs are updated
  • git remote -v -- displays the list of remote repositories associated with your Git repository along with their corresponding URLs. You have to choose the remote associated with the microsoft/FluidFramework repository. Change the remote name in these example commands if yours is not upstream.
  • git checkout -b next-merge-head upstream/next -- make a temporary branch at next.
  • git merge upstream/main-next-12c83d2 -- merge next into main-next-12c83d2
  1. Resolve any merge conflicts between the branches, then commit all the changes using the following commands:
  • git add . -- stage all the local changes
  • git commit -m "Automation: main-next integrate" -- commit the merge
  1. Fast-forward the main-next-12c83d2 branch to the merge commit and push to the remote.
  • git checkout main-next-12c83d2 -- check out the mergeBranch locally
  • git merge next-merge-head --ff-only -- fast-forward to the merge commit
  • git push upstream -- and push it to upstream (your upstream remote name may be different)
  1. Address any CI failures. If you need to make additional changes to the PR, always amend the commit using the following git commands:
  • git commit --amend -m "Automation: main-next integrate"
  • git push --force-with-lease

Once CI passes and the PR is ready to merge, add the "msftbot: merge-next" label to the PR and one of the people with merge permissions will merge it in.

…operties (#18676)

Refactors the change method to include the functionality of changing the
endpoints as well as the properties of an interval. It also updates the
signature of the (new) change method to align with the changes made to
the add signature in #17165. The changeProperties method and the old
signature of change will be deprecated and eventually removed.

AB#5738

---------

Co-authored-by: Abram Sanderson <Abram.sanderson@gmail.com>
@jzaffiro
Copy link
Contributor

Working on it

@msfluid-bot
Copy link
Collaborator Author

@fluid-example/bundle-size-tests: -492 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 455.13 KB 454.88 KB -251 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 241.67 KB 241.67 KB No change
loader.js 166.81 KB 166.82 KB +2 Bytes
map.js 46.7 KB 46.7 KB +2 Bytes
matrix.js 147.3 KB 147.31 KB +2 Bytes
odspDriver.js 90.35 KB 90.36 KB +2 Bytes
odspPrefetchSnapshot.js 41.82 KB 41.82 KB +2 Bytes
sharedString.js 165.55 KB 165.31 KB -253 Bytes
sharedTree2.js 288.6 KB 288.6 KB No change
Total Size 1.76 MB 1.76 MB -492 Bytes

Baseline commit: dd87880

Generated by 🚫 dangerJS against 271401c

@tylerbutler tylerbutler merged commit 271401c into next Dec 12, 2023
27 checks passed
@tylerbutler tylerbutler deleted the main-next-12c83d2 branch December 12, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants