Automation: main-next integrate #18798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Add example of unions like enums. Future work could polish up this utility and we could export it. For now this shows how it could be done.
#18756) Updates the existing documentation (which was previously an interior directory overview doc) to be a package README. - Updates existing formatting to better match our standard patterns - Adds basic Fluid Framework package instructions using our `markdown-magic` pragmas
Fixes a bug in #18559 where SweepReady nodes would not be Tombstoned when Sweep was disabled.
…uments (#18725) Fixes AB#6481. In light of #18559, Tombstone and Sweep should always be enabled in lockstep in terms of which documents are eligible. Today this is determined by two independent options `gcTombstoneGeneration` and `gcSweepGeneration`. We are consolidating on a single `gcGeneration` (with a back-compat measure for old docs with only `gcTombstoneGeneration`). The semantics follow the same concept: Any document stamped with the matching generation value that's current passed will be eligible for both the Tombstone and Delete stages of Sweep Phase. Importantly, if no value is passed in, Sweep is considered enabled for that document. Then in order to configure whether to run the Delete stage in a given session, there's a new GC option called `enableGCSweep` which can be set to `true` (default is don't delete, only Tombstone). ### Additional behavior change: * Small bug fix: Tombstone Enforcement was always false in the first session for a container if a tombstoneGeneration option was passed
As part of preparation for next 7.4.0 minor release. --------- Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
Updates the protocol-definitions build to produce both CJS and ESM with correct types. Also adds are-the-types-wrong to verify the types.
## Description Adds a suite of unit tests to the Gitrest GitWholeSummaryManager. ## Reviewer Guidance - I generated the `examples.ts` data from an open source app that I authored myself. The content is Lorem Ipsum based, so there is no "customer content" here.
This PR marks the odsp-client e2e test package as non-private
Projects no longer need to explicitly define a declarationDir in their tsconfig, and those that did were causing ESM type output to be placed alongside CJS source in ./dist. This PR removes the declarationDir setting from all tsconfigs.
Remaining asserts tagging for 7.4 minor release
Following https://eng.ms/docs/experiences-devices/opg/office-shared/fluid-framework/fluid-framework-internal/fluid-framework/docs/on-call/release/release-minor Running `pnpm flub generate changelog -g client`
tylerbutler
force-pushed
the
main-next-da913cd
branch
from
710cd18
to
9a451d4
Compare
⯅ @fluid-example/bundle-size-tests: +404.88 KB
Baseline commit: ef49d00 |
tylerbutler
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main-next integrate PR
DO NOT MERGE THIS PR USING THE GITHUB UI.
The aim of this pull request is to sync main and next branch. If this PR is assigned to you, you need to do the following:
git commit --amend -m "Automation: main-next integrate"git push --force-with-leaseOnce CI passes and the PR is ready to merge, add the "msftbot: merge-next" label to the PR and one of the people with merge permissions will merge it in.