Automation: main-next integrate #19435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…18797) ## Description Fixes some issues with the logic added in #16610 that prevented it from running. This should set up proper promotion to release view for well-supported (i.e. not per-build) packages, which unblocks setting up a retention policy on Fluid's primary internal publishing feed. --------- Co-authored-by: Abram Sanderson <absander@microsoft.com>
## Description Maps and lists have some issues with directly recursive schema. This change adds support for schema to opt out of implicit construction (so its valid to change their constructor types), then kludges the constructors of maps and lists so they are possible to use. This is less than ideal, but may be able to be more easily cleaned up as simple-tree and class-tree are unified. Since this is a hopefully temporary hack, the APIs for this are marked alpha not beta.
Updates the changesets for clarity and generates release notes. Command used: ```shell pnpm flub generate upcoming -g client -t major --out ./RELEASE_NOTES/2.0.0-internal.8.0.0.md ```
assert-tagging PR against main using `flub check policy --fix`
Using `pnpm flub generate changelog -g client`
more policy checks
Adds support for the 2.0 release candidate version scheme. To make the implementation simpler, the RC version scheme is the same as the internal version scheme but uses "rc" as the prerelease identifier instead of "internal". For example, `2.0.0-rc.1.0.0` will be the first RC version. Pre-release/dev builds of RC versions will be of the form `2.0.0-dev-rc.1.0.0.123456`. AB#6142
## Remove Unused IFluidDataStoreRegistry From IFluidDataStoreRuntime IFluidDataStoreRuntime optionally extended IFluidDataStoreRegistry. This is never used, so is removed. As with all provider interfaces, consumers can continue to extend the interface if they have a use and use FluidObject to inspect for it existing. ## SharedObject processGCDataCore now takes IFluidSerializer rather than SummarySerializer This change should be a no-op for consumers, and SummarySerializer and IFluidSerializer expose the same consumer facing APIs. This change just makes our APIs more consistent by only using interfaces, rather than a mix of interfaces and concrete implementations. --------- Co-authored-by: Tony Murphy <anthonm@microsoft.com>
## Description Split schema index into format and codec files to better along with docs/main/compatibility.md Implement todo to not directly consume valueSchema. Add invertMap utilitiy. Avoid setting undefined leafSchema field (this has no impact on persisted format as json drops undefined fields, but tidy's up the in memory objects while encoding). Persisted format is unchanged.
Updates most 'simple-tree' tests from SchemaBuilder -> SchemaFactory. Bugs have been opened for tests that no longer pass: AB#6557 AB#6551 AB#6549 AB#6569 --------- Co-authored-by: Joshua Smithrud <54606601+Josmithr@users.noreply.github.com>
… expect build output files to be prettier-ified (#18816)
…ile dependency (#18799) Allows the package to always use the latest and greatest, without needing to publish a new version of the lint config package and install it. Also makes testing changes in the config package easier. If we like this pattern, this will be the first such PR of potentially many :) Also updates code to address new linter rules
…18791) Also removes package-local overrides, which are no longer necessary
As a general rule, we prefer not to export classes, as it hinders our ability to make implementation changes making breaking API changes. This PR replaces the logger class export with a simple factory function.
Updated build-docs pipeline to generate API json artifacts and markdown for both 2.0 and 1.0 content. Currently, the 1.0 api content is generated locally by running api-extractor on the lts branch content and uploaded to the fluidframework container storage as 'latest-1.0.tar.gz'. The pipeline has been updated to download this blob before running the markdown documenter. In docs/package.json, a new build:multi-version script was added which calls the relevant build-docs scripts such as rollup-api-json and render-api-documentation with an additional parameter boolean parameter to signal the scripts to process content for previous version apis as well. (note that, the build-docs pipeline is currently set to run the old build script until 2.0 release) Note that the previous branch versions are maintained in two separate areas since there is no straighforward way to import pipeline parameters from another yaml file. The first is docs/data/versions.yaml and the second is the parameters in build-docs.yaml. Some checks will need to be added to ensure that the two lists match up.
This PR accomplishes the following tasks: 1. Integrates ODSP end-to-end test into the pre-existing Azure end-to-end pipeline. 2. Some code cleanup. 3. Temporarily excludes two audience test, with plans to enable it in the future. [A work item has been created for this purpose](https://dev.azure.com/fluidframework/internal/_workitems/edit/6425). 4. Rename `test-azure-frs` pipeline to `Services Client End to End Test` Example pipeline run: https://dev.azure.com/fluidframework/internal/_build/results?buildId=222063&view=results
`SharedMap.wait()` is no longer available on the current version of SharedMap or AttributableMap, but it's still referenced in the documentation, which is confusing for app developers. This PR removes the mentions of SharedMap.wait() from the SharedMap and AttributableMap docs.
## Description ~~Looks like type gens are out of date in R11s. I think this just removes the `: void` return type. Not sure why.~~ Server `build-tools` were out of date, causing unwanted type test generation diffs. Upgrading server `build-tools` dep to 0.28 from 0.26
⯆ @fluid-example/bundle-size-tests: -1.76 KB
Baseline commit: 20f2aa6 |
|
Bot: |
|
I disabled the workflow in the UI as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main-next integrate PR
DO NOT MERGE THIS PR USING THE GITHUB UI.
The aim of this pull request is to sync main and next branch. If this PR is assigned to you, you need to do the following:
git commit --amend -m "Automation: main-next integrate"git push --force-with-leaseOnce CI passes and the PR is ready to merge, add the "msftbot: merge-next" label to the PR and one of the people with merge permissions will merge it in.