gitrest: Compress latest summary with Pako deflate #20728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: server
…st/latest-summary-compression
…st/latest-summary-compression
znewton
force-pushed
the
gitrest/latest-summary-compression
branch
from
dae797a
to
898d65f
Compare
|
This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Isomorphic-Git automatically compresses everything written to storage using pako.deflate. However, when we added the "latestFullSummary" blob optimization, we did not compress it. From a local test, for simple summaries compression would reduce size by 80%.
Old summaries will not be "inflatable", so the error from attempting to inflate them is handled. This is ideal, IMO, compared to implementing our own header check in place of relying on Pako's.
This PR should be used in conjunction with #19285 because we have so-far been dependent on the "latestFullSummary" blob to check if the decompressed summary size is too large. Instead, we will have to start depending on blocking too large writes.