-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): exactOptionalPropertyTypes
clean up
#22435
Merged
jason-ha
merged 3 commits into
main
from
test/jasonha-exactOptionalPropertyTypes-cleanup
Sep 10, 2024
Merged
fix(client): exactOptionalPropertyTypes
clean up
#22435
jason-ha
merged 3 commits into
main
from
test/jasonha-exactOptionalPropertyTypes-cleanup
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select changes required to support new Presence package being built with `exactOptionalPropertyTypes: true` When exactOptionalPropertyTypes is false, a property specified as optional (via `?`) may be assigned `undefined`. When true that is not allowed. Update types to explicitly allow undefined (no effective type change as build continues to use `exactOptionalPropertyTypes: false`) or to properly respect not setting `undefined`. The latter is an implementation change, but conforms to declared specification.
github-actions
bot
added
base: main
PRs targeted against main branch
area: framework
Framework is a tag for issues involving the developer framework. Eg Aqueduct
area: loader
Loader related issues
area: runtime
Runtime related issues
area: tests
Tests to add, test infrastructure improvements, etc
public api change
Changes to a public API
labels
Sep 7, 2024
…rageService use explicit return type to avoid inference that may infer maximumCacheDurationMs as `| undefined` which is later inconsistent with `exactOptionalPropertyTypes: true`
but retain `undefined` possiblity. This matches existing implementations.
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
RishhiB
approved these changes
Sep 9, 2024
⯅ @fluid-example/bundle-size-tests: +345 Bytes
Baseline commit: c3a4565 |
Josmithr
approved these changes
Sep 9, 2024
jason-ha
deleted the
test/jasonha-exactOptionalPropertyTypes-cleanup
branch
September 10, 2024 00:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: framework
Framework is a tag for issues involving the developer framework. Eg Aqueduct
area: loader
Loader related issues
area: runtime
Runtime related issues
area: tests
Tests to add, test infrastructure improvements, etc
base: main
PRs targeted against main branch
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select changes required to support new Presence package being built with
exactOptionalPropertyTypes: true
.When exactOptionalPropertyTypes is false, a property specified as optional (via
?
) may be assignedundefined
. When true that is not allowed.Update types to explicitly allow undefined (no effective type change as most build continues to use
exactOptionalPropertyTypes: false
) or to properly respect not settingundefined
. The latter is an implementation change but conforms to declared specification.Make fix(client): make IFluidDataStoreRuntime.idCompressor non-optional but retain
undefined
possibility. This matches existing implementations.PrefetchDocumentStorageService - use explicit return type to avoid inference that may infer maximumCacheDurationMs as
| undefined
which could later be inconsistent withexactOptionalPropertyTypes: true
.