Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(fetch-tool): Cache tokens in memory #22725

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

Abe27342
Copy link
Contributor

@Abe27342 Abe27342 commented Oct 4, 2024

Description

Adds in-memory caches for tokens and AuthenticationRecords. The former works around the problem described here, and the latter makes fetch-tool behave well when used with multiple accounts (which is mostly only a scenario for FF developers using it on stress or e2e test documents).

@github-actions github-actions bot added the base: main PRs targeted against main branch label Oct 4, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 460.47 KB 460.5 KB +35 Bytes
azureClient.js 557.45 KB 557.5 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 259.74 KB 259.76 KB +14 Bytes
fluidFramework.js 405.91 KB 405.92 KB +14 Bytes
loader.js 134.34 KB 134.36 KB +14 Bytes
map.js 42.46 KB 42.46 KB +7 Bytes
matrix.js 148.63 KB 148.64 KB +7 Bytes
odspClient.js 524.41 KB 524.46 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.82 KB 164.83 KB +7 Bytes
sharedTree.js 396.37 KB 396.38 KB +7 Bytes
Total Size 3.31 MB 3.31 MB +245 Bytes

Baseline commit: 09d786a

Generated by 🚫 dangerJS against ef72056

@Abe27342 Abe27342 merged commit 2e945a4 into microsoft:main Oct 4, 2024
30 checks passed
@Abe27342 Abe27342 deleted the cache-odsp-tokens branch October 4, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants